upgradewallet
RPC.
wallet: Remove upgradewallet
RPC
#32944
pull
w0xlt
wants to merge
1
commits into
bitcoin:master
from
w0xlt:remove_upgradewallet_rpc
changing
6
files
+0 −107
-
w0xlt commented at 9:55 pm on July 10, 2025: contributorBased on discussions in #32803, this PR proposes removing the
-
wallet: Remove `upgradewallet` RPC 85eb29605e
-
DrahtBot added the label Wallet on Jul 10, 2025
-
DrahtBot commented at 9:55 pm on July 10, 2025: contributor
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32944.
Reviews
See the guideline for information on the review process.
Type Reviewers ACK pablomartin4btc Concept ACK Prabhat1308 If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
Conflicts
Reviewers, this pull request conflicts with the following ones:
- #32636 (Split
CWallet::Create()
intoCreateNew
andLoadExisting
by davidgumberg)
If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.
- #32636 (Split
-
pablomartin4btc commented at 1:27 am on July 11, 2025: memberACK 85eb29605ef4051ba23cd32e54a3d5a3ee203f6c
-
maflcko commented at 5:16 am on July 11, 2025: memberneeds release note?
-
in src/wallet/wallet.cpp:3215 in 85eb29605e
3210- error = strprintf(_("Cannot upgrade a non HD split wallet from version %i to version %i without upgrading to support pre-split keypool. Please use version %i or no version specified."), prev_version, version, FEATURE_PRE_SPLIT_KEYPOOL); 3211- return false; 3212- } 3213- 3214- // Permanently upgrade to the version 3215- SetMinVersion(GetClosestWalletFeature(version));
Prabhat1308 commented at 6:58 am on July 11, 2025:There is another solitary instance ofSetMinVersion
in this file . SinceCreatewallet
will create a wallet with the newest version , that use is also a dead code . Might as well remove this function too.Prabhat1308 commented at 6:59 am on July 11, 2025: contributorConcept ACK
github-metadata-mirror
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-11 09:13 UTC
This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-07-11 09:13 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me
More mirrored repositories can be found on mirror.b10c.me