wallet: Remove upgradewallet RPC #32944

1. 
   w0xlt commented at 9:55 pm on July 10, 2025: contributor

   Based on discussions in #32803, this PR proposes removing the upgradewallet RPC.
2. wallet: Remove `upgradewallet` RPC 85eb29605e
3. DrahtBot added the label Wallet on Jul 10, 2025
4. 
   DrahtBot commented at 9:55 pm on July 10, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32944.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	pablomartin4btc
   Concept ACK	Prabhat1308

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #32636 (Split CWallet::Create() into CreateNew and LoadExisting by davidgumberg)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

5. 
   pablomartin4btc commented at 1:27 am on July 11, 2025: member

   ACK 85eb29605ef4051ba23cd32e54a3d5a3ee203f6c
6. 
   maflcko commented at 5:16 am on July 11, 2025: member

   needs release note?
7. in src/wallet/wallet.cpp:3215 in 85eb29605e

   3210-        error = strprintf(_("Cannot upgrade a non HD split wallet from version %i to version %i without upgrading to support pre-split keypool. Please use version %i or no version specified."), prev_version, version, FEATURE_PRE_SPLIT_KEYPOOL);
   3211-        return false;
   3212-    }
   3213-
   3214-    // Permanently upgrade to the version
   3215-    SetMinVersion(GetClosestWalletFeature(version));
   

   ---

   ---

   

   Prabhat1308 commented at 6:58 am on July 11, 2025:

   There is another solitary instance of SetMinVersion in this file . Since Createwallet will create a wallet with the newest version , that use is also a dead code . Might as well remove this function too.
8. 
   Prabhat1308 commented at 6:59 am on July 11, 2025: contributor

   Concept ACK

Contributors
w0xlt DrahtBot pablomartin4btc maflcko Prabhat1308

Labels
Wallet