contrib: Check build options for gen-manpages #32949

1. 
   duduta commented at 1:48 pm on July 11, 2025: none

   This fixes #17506. Let me know what you think.
2. DrahtBot added the label Scripts and tools on Jul 11, 2025
3. 
   DrahtBot commented at 1:48 pm on July 11, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32949.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #32297 (bitcoin-cli: Add -ipcconnect option by ryanofsky)
   • #30437 (ipc: add bitcoin-mine test program by ryanofsky)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. DrahtBot added the label CI failed on Jul 11, 2025
5. 
   DrahtBot commented at 1:53 pm on July 11, 2025: contributor

   🚧 At least one of the CI tasks failed. Task lint: https://github.com/bitcoin/bitcoin/runs/45803395401 LLM reason (✨ experimental): Lint check failed due to a Python code style error identified by ruff.

   Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

   • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

   • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

   • An intermittent issue.

   Leave a comment here, if you need help tracking down a confusing failure.

6. duduta force-pushed on Jul 11, 2025
7. 
   maflcko commented at 2:01 pm on July 11, 2025: member

   This fixes #17506. Let me know what you think.

   Have you read the issue? It mentions HAVE_SYSTEM and others, but they are not checked here.

   Is this llm generated?

8. duduta marked this as a draft on Jul 11, 2025
9. duduta force-pushed on Jul 11, 2025
10. Check config.ini for installed binaries d5119539a2
11. Add BUILD_GUI var to config.ini.in 2ffd8c27aa
12. 
    duduta commented at 2:41 pm on July 11, 2025: none

    @maflcko Oh, sorry. I should have asked first. Right now, if one builds, for example, with ZMQ, the bitcoind –help reflects that, which is reflected in the man pages that are generated for bitcoind. The same is true for HAVE_SYSTEM (-alertnotify does appear in the man pages generated for bitcoind). As for USE_UPNP, I have grepped for it, couldn’t even find it in the sources. So I did a first step at least: to check config.ini for the list of binaries that should have been built. I am open to suggestions :)
13. DrahtBot removed the label CI failed on Jul 11, 2025

Contributors
duduta DrahtBot maflcko

Labels
Scripts and tools