Wallet RPC calls integration test #3295

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:wallet_integrationtest changing 4 files +190 −0

gavinandresen commented at 7:21 AM on November 21, 2013: contributor

qa/rpc-tests/wallet.sh runs a three-node -regtest network, generates a fresh blockchain, and then exercises basic wallet sending/receiving functionality using command-line RPC.

Depends on #3294
in src/rpcmining.cpp:None in c113fa3dad outdated
```
 190 | +            }
 191 | +        }
 192 | +    }
 193 | +    else // Not -regtest: start generate thread, return immediately
 194 | +    {
 195 | +        mapArgs["-gen"] = (fGenerate ? "1" : "0");
```
laanwj commented at 10:51 AM on November 21, 2013:

As the setgenerate command was set to no longer require a wallet, shouldn't a check for pWalletMain be added here? (or can the mining thread run without wallet as well, I wouldn't know for sure)

gavinandresen commented at 10:54 AM on November 21, 2013:

Good catch, I believe it should check for a non-null wallet.
in src/rpcmining.cpp:None in e3f61902e5 outdated
```
 144 | @@ -144,21 +145,54 @@ Value setgenerate(const Array& params, bool fHelp)
 145 |              + HelpExampleRpc("setgenerate", "true, 1")
 146 |          );
 147 |  
 148 | +    if (pwalletMain == NULL)
 149 | +        throw JSONRPCError(RPC_METHOD_NOT_FOUND, "Method not found (disabled)");
```
laanwj commented at 11:33 AM on November 21, 2013:

But if you put a check here, the regtest specific setgenerate will also no longer work without wallet, which was the point of changing fReqWallet in the big table, I suppose, or am I missing something?

gavinandresen commented at 12:18 PM on November 21, 2013:

I needed to set fReqWallet to false so the wallet mutex is not acquired, avoiding deadlock with the mining thread.

laanwj commented at 12:22 PM on November 21, 2013:

OK, ACK then
laanwj commented at 2:55 PM on November 25, 2013: member

This probably could use a rebase as cdb6960 and b4feb33 have been merged.

Integration tests via RPC calls

qa/rpc-tests/wallet.sh runs a three-node -regtest network,
generates a fresh blockchain, and then exercises basic wallet
sending/receiving functionality using command-line RPC.

9e7776bf1f

BitcoinPullTester commented at 4:58 AM on November 27, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/9e7776bf1f1aebbd6e1ef21a4144ba72a54985de for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 207cfbfbf1 on Nov 28, 2013
laanwj merged this on Nov 28, 2013
laanwj closed this on Nov 28, 2013
gavinandresen deleted the branch on Mar 13, 2014
Bushstar referenced this in commit a8213cadb9 on Apr 8, 2020
Bushstar referenced this in commit b57901dfaa on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

gavinandresen

laanwj

BitcoinPullTester

Linked (view graph)

#3294 setgenerate creates multiple blocks in -regtest mode