wallet: Always rewrite tx records during migration #32985

1. 
   achow101 commented at 0:01 am on July 16, 2025: member

   Since loading a wallet may change some parts of tx records (e.g. adding nOrderPos), we should rewrite the records instead of copying them so that the automatic upgrade does not need to be performed again when the wallet is loaded.

   This is useful for future PRs I’m working on where we need to be sure about what data exists in a tx record in descriptor wallets.

2. DrahtBot added the label Wallet on Jul 16, 2025
3. 
   DrahtBot commented at 0:01 am on July 16, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32985.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #33034 (wallet: Store transactions in a separate sqlite table by achow101)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. wallet: Always rewrite tx records during migration

   Since loading a wallet may change some parts of tx records (e.g. adding
   nOrderPos), we should rewrite the records instead of copying them so
   that the automatic upgrade does not need to be performed again when the
   wallet is loaded.

   af041c4057
5. achow101 force-pushed on Jul 21, 2025

Contributors
achow101 DrahtBot

Labels
Wallet