log: unify UpdateTip values #32996

pull l0rinc wants to merge 1 commits into bitcoin:master from l0rinc:l0rinc/UpdateTip-date-adjustment changing 1 files +1 −1
  1. l0rinc commented at 6:00 pm on July 16, 2025: contributor

    The most frequently seen log line prints tip-update data after each successful block connection. During IBD this produces ~900k lines (~250 characters per line), totaling ~220 MB so far.

    Most key=value pairs are written directly, but block time is emitted as date='ISO8601DateTime', adding unnecessary single quotes because the value contains no spaces.

    Removing those quotes shortens every line and reduces a full-IBD debug log by ~1% (about ~2MB).

    Before:

    2025-07-16T04:50:47Z UpdateTip: new best=00000000000000000001f49fb5fb37753c06d78f1a811d707aebf6194bb147e5 height=890000 version=0x25e9a000 log2_work=95.523053 tx=1172414692 date=‘2025-03-29T17:29:01Z’ progress=0.964378 cache=1578.9MiB(11964898txo)

    After:

    2025-07-16T04:50:47Z UpdateTip: new best=00000000000000000001f49fb5fb37753c06d78f1a811d707aebf6194bb147e5 height=890000 version=0x25e9a000 log2_work=95.523053 tx=1172414692 date=2025-03-29T17:29:01Z progress=0.964378 cache=1578.9MiB(11964898txo)

  2. log: unify `UpdateTip` values
    The most frequently seen log line prints tip-update data after each successful block connection.
    During IBD this produces ~900k lines (~250 characters per line), totaling ~220 MB so far.
    
    Most `key=value` pairs are written directly, but block time is emitted as `date='ISO8601DateTime'`, adding unnecessary single quotes because the value contains no spaces.
    
    Removing those quotes shortens every line and reduces a full-IBD debug log by ~1% (about ~2MB).
    
    Before:
    > 2025-07-16T04:50:47Z UpdateTip: new best=00000000000000000001f49fb5fb37753c06d78f1a811d707aebf6194bb147e5 height=890000 version=0x25e9a000 log2_work=95.523053 tx=1172414692 date='2025-03-29T17:29:01Z' progress=0.964378 cache=1578.9MiB(11964898txo)
    
    After:
    > 2025-07-16T04:50:47Z UpdateTip: new best=00000000000000000001f49fb5fb37753c06d78f1a811d707aebf6194bb147e5 height=890000 version=0x25e9a000 log2_work=95.523053 tx=1172414692 date=2025-03-29T17:29:01Z progress=0.964378 cache=1578.9MiB(11964898txo)
    b039305d35
  3. DrahtBot added the label Utils/log/libs on Jul 16, 2025
  4. DrahtBot commented at 6:00 pm on July 16, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/32996.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK nervana21

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. nervana21 commented at 11:05 pm on July 16, 2025: contributor

    tACK b039305

    Before:

    2025-07-16T22:31:33Z UpdateTip: new best=000000000000000000022dabca47b7aabc24d93d0241536ca75dc528d08d5eba height=905352 version=0x20c26000 log2_work=95.713336 tx=1212933015 date=‘2025-07-13T11:06:38Z’ progress=0.998857 cache=8.8MiB(61209txo)

    After:

    2025-07-16T22:54:20Z UpdateTip: new best=0000000000000000000186eed935e4ad209e7aaa4ceeb2542851feaf4b8d426f height=905353 version=0x21624000 log2_work=95.713348 tx=1212936957 date=2025-07-13T11:25:43Z progress=0.998856 cache=2.1MiB(14143txo)


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-02 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me