The CI currently inherits almost all env vars from the host. This was problematic in the past and causing non-determinism, e.g. the fix in commit fa12558d21aa03c22407a1458a0345d8a7ab6a4b. It is still problematic today, see e.g. #31349 (comment), or #32935
This fixes #32935 by only passing env vars documented in ./ci/test/00_setup_env.sh.
Implementation-wise, instead of cramming the python code into the python -c "" statement, just start a fresh py file, which is easier to handle.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33002.
See the guideline for information on the review process. A summary of reviews will appear here.
🚧 At least one of the CI tasks failed.
Task lint: https://github.com/bitcoin/bitcoin/runs/46202380371
LLM reason (✨ experimental): The CI failure is caused by a Python linter warning about using open() without specifying utf8 encoding.
Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:
Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.
A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.
An intermittent issue.
Leave a comment here, if you need help tracking down a confusing failure.