[Qt] allow deletion of payment-requests in sendcoins #3306

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:delete_paymentEntries changing 5 files +158 −130

Diapolo commented at 12:59 PM on November 22, 2013: none
- this adds a delete button for insecure and secure payment requests in the sendcoins dialog
- it also enables the delete button even for single and empty entries, as this is much easier to handle and doesn't need to special case single entries
- big parts of the ui file were changed, because I copied the delete button and had to delete the layout too and created it from scratch (which seems to cleanup the rows and colums in the layout also, which is nice IMHO) @laanwj Would be nice, if you could take some time to review my open Qt pulls and merge, if you ACK them.

[Qt] allow deletion of payment-requests in sendcoins

- this adds a delete button for insecure and secure payment requests in
  the sendcoins dialog
- it also enables the delete button even for single and empty entries, as
  this is much easier to handle and doesn't need to special case single
  entries
- big parts of the ui file were changed, because I copied the delete
  button and had to delete the layout too and created it from scratch
  (which seems to cleanup the rows and colums in the layout also, which is
  nice IMHO)

84b695cc9d

in src/qt/sendcoinsdialog.cpp:None in 15913b9a14 outdated
```
 297 | @@ -300,27 +298,21 @@ SendCoinsEntry *SendCoinsDialog::addEntry()
 298 |      return entry;
 299 |  }
 300 |  
 301 | -void SendCoinsDialog::updateRemoveEnabled()
 302 | +void SendCoinsDialog::updateTabsCCLabels()
```
laanwj commented at 3:17 PM on November 24, 2013:

The name updateTabsCCLabels is hard to read, maybe updateTabsAndLabels?

Diapolo commented at 3:23 PM on November 24, 2013:

Current name is ugly as hell, thanks you came up with that one :). I'll change this...

Edit: Changed :).
BitcoinPullTester commented at 4:03 PM on November 24, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/84b695cc9d4dc90b1ccb99e2d92e1e76e138d911 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 4:22 PM on November 27, 2013: member

Looks good and code changes are OK, But haven't fully tested yet
laanwj referenced this in commit 40ad6e7f35 on Dec 1, 2013
laanwj merged this on Dec 1, 2013
laanwj closed this on Dec 1, 2013
Diapolo deleted the branch on Dec 1, 2013
Bushstar referenced this in commit f23e722daf on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester