rpc, wallet: replace remaining hardcoded output types with FormatAllOutputTypes #33065

1. 
   theStack commented at 4:56 pm on July 25, 2025: contributor

   This PR takes use of the FormatAllOutputTypes helper (introduced in PR #32432, commit 8cc9845b8ddf4f93a02c622e7df8d1095dc1a640) to get rid of the remaining hardcoded output types in wallet RPC and command line arguments documentation [1]. Note that it can’t be used in the createmultisig RPC, as this one is only for pre-taproot output types and hence doesn’t contain “bech32m” in the list.

   [1] instances were found via $ git grep legacy.*p2sh-segwit ./src/rpc/ ./src/wallet/

2. rpc, wallet: replace remaining hardcoded output types with `FormatAllOutputTypes`

   This commit takes use of the `FormatAllOutputTypes` helper
   (introduced in PR #32432, commit 8cc9845b8ddf4f93a02c622e7df8d1095dc1a640)
   to get rid of the hardcoded output types in wallet RPC documentation.
   Note that it can't be used in the `createmultisig` RPC, as this one is
   only for pre-taproot output types and hence doesn't contain "bech32m" in the list.

   e3ba0757a9
3. 
   DrahtBot commented at 4:56 pm on July 25, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33065.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	pablomartin4btc, nervana21, maflcko, rkrux

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #32966 (Silent Payments: Receiving by Eunovo)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

4. 
   pablomartin4btc commented at 9:54 pm on July 25, 2025: member

   utACK e3ba0757a9410336e904a1b108d86165f347fc52

   What about these 2 (-addresstype and -changetype) in src/wallet/init.cpp?

   https://github.com/bitcoin/bitcoin/blob/2e97541396b998f6dfb47f9acef51e3ca69e97b2/src/wallet/init.cpp#L44-L51

5. init, wallet: replace hardcoded output types with `FormatAllOutputTypes` 251d020846
6. 
   theStack commented at 10:29 pm on July 25, 2025: contributor

   What about these 2 (-addresstype and -changetype) in src/wallet/init.cpp?

   Thanks, missed those due to grepping too tightly, added another commit.

7. pablomartin4btc approved
8. 
   pablomartin4btc commented at 10:56 pm on July 25, 2025: member

   re-utACK 251d02084688c67523e9ec92ec79ee657454ab93
9. 
   nervana21 commented at 5:21 pm on July 26, 2025: contributor

   tACK 251d020

   I ran all affected help commands and confirmed that all updated outputs are as expected

10. 
    maflcko commented at 10:21 am on July 28, 2025: member

    review ACK 251d02084688c67523e9ec92ec79ee657454ab93 🌨

    Signature:

    0untrusted comment: signature from minisign secret key on empty file; verify via: minisign -Vm "${path_to_any_empty_file}" -P RWTRmVTMeKV5noAMqVlsMugDDCyyTSbA3Re5AkUrhvLVln0tSaFWglOw -x "${path_to_this_whole_four_line_signature_blob}"
    1RUTRmVTMeKV5npGrKx1nqXCw5zeVHdtdYURB/KlyA/LMFgpNCs+SkW9a8N95d+U4AP1RJMi+krxU1A3Yux4bpwZNLvVBKy0wLgM=
    2trusted comment: review ACK 251d02084688c67523e9ec92ec79ee657454ab93 🌨
    3ne4xj6IYoPFwPiqSeFarPo3YE5F3okDnDRwUE/1k0dqtdcV76FVysxYZ/2G0wPWvIrMWHvvmfi4iF5GvheCxCQ==
    

11. rkrux approved
12. 
    rkrux commented at 10:32 am on July 28, 2025: contributor

    crACK 251d02084688c67523e9ec92ec79ee657454ab93

    Nit: can update the grep command in the PR description.

13. 
    theStack commented at 12:43 pm on July 28, 2025: contributor

    Nit: can update the grep command in the PR description.

    Done.

14. fanquake merged this on Jul 28, 2025
15. fanquake closed this on Jul 28, 2025

    ---

16. theStack deleted the branch on Jul 28, 2025

Contributors
theStack DrahtBot pablomartin4btc nervana21 maflcko rkrux