doc: Add legacy wallet removal release notes #33075

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2507-doc-less-bdb changing 2 files +12 −3

maflcko commented at 9:34 am on July 28, 2025: member

This spans over several pulls, so add a single note for all of them.
DrahtBot added the label Docs on Jul 28, 2025

DrahtBot commented at 9:34 am on July 28, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33075.

Reviews

See the guideline for information on the review process.

Type	Reviewers
ACK	pablomartin4btc, janb84, glozow, achow101
Concept ACK	w0xlt
Stale ACK	rkrux

If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

rkrux approved
rkrux commented at 10:20 am on July 28, 2025: contributor

ACK fa21a90c3558c8414aafe0e5b68d8b9590cca127
janb84 commented at 11:37 am on July 28, 2025: contributor

ACK fa21a90c3558c8414aafe0e5b68d8b9590cca127

PR adds a release note for several related legacy wallet removal PR’s
doc: Add legacy wallet removal release notes fa45ccc15d

in doc/release-notes-32944-28710-32438-31250.md:11 in fa21a90c35 outdated

 6+
 7+The legacy wallet removal drops redundant options in the bitcoin-wallet tool,
 8+such as `-withinternalbdb`, `-legacy`, and `-descriptors`. Moreover, the
 9+legacy-only RPCs `importmulti`, `sethdseed`, `addmultisigaddress`,
10+`importaddress`, `importpubkey`, `importprivkey`, `newkeypool`, `dumpprivkey`,
11+`dumpwallet`, `importwallet`, `upgradewallet`, and `newkeypool` are removed.

pablomartin4btc commented at 1:40 pm on July 28, 2025:

nit: newkeypool was already mentioned earlier…

0`dumpwallet`, `importwallet` and `upgradewallet` are removed.

maflcko force-pushed on Jul 28, 2025
pablomartin4btc approved
pablomartin4btc commented at 3:14 pm on July 28, 2025: member

ACK fa45ccc15dfc52e798da62548dc43d1bd7889c9a
DrahtBot requested review from rkrux on Jul 28, 2025
DrahtBot requested review from janb84 on Jul 28, 2025
janb84 commented at 3:21 pm on July 28, 2025: contributor
re ACK fa45ccc15dfc52e798da62548dc43d1bd7889c9a

changes since last ACK:
- removed double mention of newkeypool

in doc/release-notes-32944-28710-32438-31250.md:12 in fa45ccc15d

 7+The legacy wallet removal drops redundant options in the bitcoin-wallet tool,
 8+such as `-withinternalbdb`, `-legacy`, and `-descriptors`. Moreover, the
 9+legacy-only RPCs `addmultisigaddress`, `dumpprivkey`, `dumpwallet`,
10+`importaddress`, `importmulti`, `importprivkey`, `importpubkey`,
11+`importwallet`, `newkeypool`, `sethdseed`, and `upgradewallet`, are removed.
12+(#32944, #28710, #32438, #31250)

jonatack commented at 5:55 pm on July 28, 2025:

nit, would sort the PRs from oldest to newest

in doc/release-notes-32944-28710-32438-31250.md:4 in fa45ccc15d

0@@ -0,0 +1,12 @@
1+# Legacy Wallet Removal
2+
3+BDB legacy wallets can no longer be created or loaded. They can be migrated to
4+the new descriptor wallet format. Refer to the `migratewallet` RPC for more

jonatack commented at 5:56 pm on July 28, 2025:

0the newer descriptor wallet format. Refer to the `migratewallet` RPC for more

in doc/release-notes-32944-28710-32438-31250.md:11 in fa45ccc15d

 6+
 7+The legacy wallet removal drops redundant options in the bitcoin-wallet tool,
 8+such as `-withinternalbdb`, `-legacy`, and `-descriptors`. Moreover, the
 9+legacy-only RPCs `addmultisigaddress`, `dumpprivkey`, `dumpwallet`,
10+`importaddress`, `importmulti`, `importprivkey`, `importpubkey`,
11+`importwallet`, `newkeypool`, `sethdseed`, and `upgradewallet`, are removed.

jonatack commented at 5:57 pm on July 28, 2025:

0`importwallet`, `newkeypool`, `sethdseed`, and `upgradewallet`, have been removed.

in doc/release-notes-32944-28710-32438-31250.md:8 in fa45ccc15d

0@@ -0,0 +1,12 @@
1+# Legacy Wallet Removal
2+
3+BDB legacy wallets can no longer be created or loaded. They can be migrated to
4+the new descriptor wallet format. Refer to the `migratewallet` RPC for more
5+details.
6+
7+The legacy wallet removal drops redundant options in the bitcoin-wallet tool,
8+such as `-withinternalbdb`, `-legacy`, and `-descriptors`. Moreover, the

jonatack commented at 5:58 pm on July 28, 2025:

Nice touch sorting the RPCs by alphabetical order; maybe do the same for these options.

jonatack commented at 5:59 pm on July 28, 2025: member

Thanks for picking this up – looks good modulo a few suggestions.
glozow commented at 7:40 pm on July 28, 2025: member

lgtm ACK fa45ccc15dfc52e798da62548dc43d1bd7889c9a
glozow requested review from achow101 on Jul 29, 2025
w0xlt commented at 5:54 pm on July 29, 2025: contributor

ACK https://github.com/bitcoin/bitcoin/pull/33075
achow101 commented at 5:57 pm on July 29, 2025: member

ACK fa45ccc15dfc52e798da62548dc43d1bd7889c9a
DrahtBot requested review from w0xlt on Jul 29, 2025
achow101 merged this on Jul 29, 2025
achow101 closed this on Jul 29, 2025
maflcko deleted the branch on Jul 30, 2025

Contributors
maflcko DrahtBot rkrux janb84 pablomartin4btc jonatack glozow w0xlt achow101

Review Requested
achow101 rkrux w0xlt

Labels
Docs