cmake: Do not require Python to build GUI #33156

pull hebasto wants to merge 2 commits into bitcoin:master from hebasto:250808-update-tr changing 2 files +5 −1
  1. hebasto commented at 12:51 pm on August 8, 2025: member

    This PR fixes #33146, which may be considered a regression introduced in #31233.

    This approach was chosen for its minimal diff.

    An alternative approach would be to convert the translate build target into a CMake script. This could be justified, as the goal is to update files in the source tree and then commit them to the repository, which is something regular build targets are not intended to do.

    On a related note, the share/qt/extract_strings_qt.py looks simple enough to be rewritten in pure CMake code.

  2. cmake: Do not require Python to build GUI 92abda5cd5
  3. doc: Mention that Python is required for translations
    Python is used by the `translate` build target to update the
    translation source files from the codebase.
    55c11e846b
  4. hebasto added the label Docs on Aug 8, 2025
  5. hebasto added the label Build system on Aug 8, 2025
  6. DrahtBot commented at 12:51 pm on August 8, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33156.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK pablomartin4btc
    Concept ACK Sammie05

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  7. Sammie05 commented at 1:05 am on August 10, 2025: none

    This is a solid improvement and should be especially beneficial for developers without Python environments and enhances our build system’s efficiency by reducing dependencies. Great work!

    ACK

  8. pablomartin4btc commented at 5:10 pm on August 11, 2025: member

    ACK 55c11e846b261fb2514a0846a07efa36aaf01e30

    An alternative approach would be to convert the translate build target into a CMake script.

    I think that would help resolve some diffs we occasionally see, which I suspect could be caused by subtle variations in how Python versions (locale settings, or encoding defaults) format or order strings during translation processing. This change should make the translation output consistent across environments.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-13 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me