This PR adds a functional test to repeat the existing malleability check for oversized coinbase witness nonce size using a block that is small enough to be relayed over the P2P network.
This addresses the TODO in test_block_malleability by ensuring behavior is consistent between submitblock RPC and P2P relay.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33172.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
ACK 19c5dba
Tested on macOS, completed successfully in ~64 seconds.
The implementation properly addresses the TODO comment by adding P2P test coverage for block malleability. Uses 100KB witness data - large enough to trigger bad-witness-nonce-size but small enough to stay under MAX_BLOCK_WEIGHT. Follows existing patterns and tests both rejection and acceptance paths consistently.
Good addition to test coverage.
ACK 19c5dba8ca8ff66f3a8d4a62e2145c67e81e6a6f
PR Replaces TODO with test code that tests a rejection of a P2P transmitted invalid block (as suggested by TODO).
Test on master : ~63 sec , test with PR : ~63 sec no significant impact ✅
Corecheck does not report any increase of test coverage with this change, but it does not have (much) impact on test duration. Seems somewhat preferable to test this scenario there for (weak) ACK.
841+ # same validation rejection but keeps the block under the weight limit
842+ # so it can be sent via P2P.
843+ relayable_block.vtx[0].wit.vtxinwit[0].scriptWitness.stack.append(b'a' * 100_000)
844+
845+ # Ensure it's relayable by weight
846+ assert relayable_block.get_weight() <= MAX_BLOCK_WEIGHT
assert_greater_than_or_equal.
Adds a functional test that repeats the existing witness nonce size
malleability check using a block under MAX_BLOCK_WEIGHT so it can be
relayed over the P2P network, addressing the TODO in test_block_malleability.
Includes rejection check for 'bad-witness-nonce-size' and confirmation
that a corrected block is accepted.
853+ assert_not_equal(self.nodes[0].getbestblockhash(), relayable_block.hash_hex)
854+
855+ # Now fix the block by removing the extra witness data
856+ relayable_block.vtx[0].wit.vtxinwit[0].scriptWitness.stack.pop()
857+
858+ # Confirm the block is still relayable
Confirm the block is still relayable by weight, As this is not checking whether a block is relayable its just checking weight.
re ACK d0e1bbad016cc4949094daea2934712f92dfeecd
Changes since last ACK;