Release: Prepare “Translation string freeze” step #33193

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:250815-translations changing 3 files +689 −818
  1. hebasto commented at 12:58 pm on August 15, 2025: member

    This PR follows our Release Process.

    It is required for the translation string freeze, as the following PRs introduced new translatable strings:

    • #31296:https://github.com/bitcoin/bitcoin/blob/7b4a1350dfd6b3892a9c314eeff28b22ef0c1a73/src/wallet/wallet.h#L945

    • #31453:https://github.com/bitcoin/bitcoin/blob/7b4a1350dfd6b3892a9c314eeff28b22ef0c1a73/src/init.cpp#L1878-L1879

    • #32896:https://github.com/bitcoin/bitcoin/blob/22e689587a7ae02f82ad2464017731f3b23b5363/src/wallet/spend.cpp#L288-L292

    Notes for reviewers:

    1. To reproduce the diff, run:
    0cmake --preset dev-mode
    1cmake --build build_dev_mode --target translate
    
    1. The structure of bitconstrings.cpp has been altered due to #33209.

    2. The diff in bitcoin_en.xlf contains many unrelated metadata changes, so it may be easier to verify the changes in bitcoin_en.ts.

  2. hebasto added this to the milestone 30.0 on Aug 15, 2025
  3. DrahtBot commented at 12:58 pm on August 15, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33193.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK janb84
    Concept ACK ismaelsadeeq

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

    Conflicts

    No conflicts as of last run.

  4. ismaelsadeeq commented at 1:45 pm on August 15, 2025: member
    Concept ACK
  5. DrahtBot added the label CI failed on Aug 15, 2025
  6. DrahtBot commented at 3:00 pm on August 15, 2025: contributor

    🚧 At least one of the CI tasks failed. Task MSan, depends: https://github.com/bitcoin/bitcoin/runs/48168334297 LLM reason (✨ experimental): The CI failure is caused by the failure of the “logging_tests” test suite.

    Try to run the tests locally, according to the documentation. However, a CI failure may still happen due to a number of reasons, for example:

    • Possibly due to a silent merge conflict (the changes in this pull request being incompatible with the current code in the target branch). If so, make sure to rebase on the latest commit of the target branch.

    • A sanitizer issue, which can only be found by compiling with the sanitizer and running the affected test.

    • An intermittent issue.

    Leave a comment here, if you need help tracking down a confusing failure.

  7. DrahtBot removed the label CI failed on Aug 15, 2025
  8. hebasto force-pushed on Aug 18, 2025
  9. hebasto marked this as ready for review on Aug 18, 2025
  10. hebasto commented at 11:22 am on August 18, 2025: member
    Rebased on top of the merged #33200 and undrafted.
  11. janb84 commented at 12:30 pm on August 18, 2025: contributor

    ACK d32fcd3df22671b633cae605ed06c6d0a353e2bf

    PR updates translation strings, for 30.0 freeze.

    Ran the commands against this PR; got 0 changes (reproduced the results) ✅ Ran the commands against Master; got the changes as provided in this PR ✅

  12. DrahtBot requested review from ismaelsadeeq on Aug 18, 2025
  13. qt: Update `src/qt/locale/bitcoin_en.xlf` translation source file
    Steps to reproduce the diff:
    ```
    cmake --preset dev-mode
    cmake --build build_dev_mode --target translate
    ```
    0df2c3c42e
  14. hebasto force-pushed on Aug 19, 2025
  15. hebasto commented at 1:33 pm on August 19, 2025: member
    Rebased.
  16. janb84 commented at 1:49 pm on August 19, 2025: contributor

    re ACK 0df2c3c42e8a3ee3da4ca6c4b9b9c28060bb1fe3

    changes since last ACK:

    • rebase (churn is inline with changes from #33209 )
  17. fanquake merged this on Aug 20, 2025
  18. fanquake closed this on Aug 20, 2025


hebasto DrahtBot ismaelsadeeq janb84


ismaelsadeeq

Milestone
30.0


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-08-21 09:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me