bitcoin-cli: remove unneeded dependencies (only minor code movement) #3320

Remove unnecessary dependencies for bitcoin-cli (leveldb, berkelydb, wallet, RPC server)

Build system changes:

• split libbitcoin.a into libbitcoin_common.a, libbitcoin_server.a and libbitcoin_cli.a

Code changes (movement only):

• split up HelpMessage into HelpMessage in init.cpp and HelpMessageCli in rpcclient.cpp
• move uiInterface from init.cpp to util.cpp

@sipa now using a different solution for HelpMessage, in which I split off the cli part to a seperate function and leave the main part in init.cpp. As added benefit this cleans up the function in init.cpp a lot by only having to consider two instead of three cases.

If ok, I'l rebase #3332 on top.

Compiling with -DDEBUG_LOCKORDER I get EnterCritical/LeaveCritical undefined compiling bitcoin-cli.

Maybe sync.cpp needs to be compiled into libbitcoin_common?

@gavinandresen thanks for testing

I think that's indeed the most straightforward solution. There is no functional reason for sync.cpp to be linked into the -cli, as it does not use threading, but I've consciously avoided splitting up util.cpp here (and it's util.cpp that pulls it in).

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/0b47fe6bdc14e942bc886a08a55cc183c6820636 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

Ok, works with DEBUG_LOCKORDER now.

Btw: would it be useful to have a configure flag to enable DEBUG_LOCKORDER? Maybe something like --debug-threads?

ACK.