rpc: require integer verbosity; remove boolean ‘verbose’ #33213

1. 
   fqlx commented at 2:02 am on August 19, 2025: none

   Summary

   Standardize RPC verbosity to integers only and remove boolean handling for clarity, consistency, and future extensibility.

   Rationale

   • Legacy cleanup: Boolean verbosity has been discouraged/deprecated in docs since 2017 and continues to create tech debt (special-case parsing, inconsistent tests, user confusion).
   • Consistency: Integers enable multi-level output without overloading a boolean.

   User-visible changes

   • getblock, getrawtransaction, getrawmempool no longer accept booleans.
   • Passing true/false now errors with: Verbosity was boolean but only integer allowed.
   • Migration: false → 0, true → 1.

   Code / Docs

   • ParseVerbosity(arg, default) now rejects booleans (removed allow_bool).
   • Call sites and functional tests updated to use integer levels.
   • Developer notes updated; release notes added.

   Breaking change: scripts/tools using boolean verbosity must switch to integers.

2. rpc: require integer verbosity; remove boolean 'verbose'

   - Drop allow_bool from ParseVerbosity() and update callers.
   - getblock/getrawtransaction/getrawmempool now reject true/false.
   - Update docs + release notes; switch tests to 0/1.

   d699be1751
3. DrahtBot added the label RPC/REST/ZMQ on Aug 19, 2025
4. 
   DrahtBot commented at 2:02 am on August 19, 2025: contributor

   ♻️ Automatically closing for now based on heuristics. Please leave a comment, if this was erroneous. Generally, please focus on creating high-quality, original content that demonstrates a clear understanding of the project’s requirements and goals.
5. DrahtBot closed this on Aug 19, 2025

   ---

6. 
   DrahtBot commented at 2:02 am on August 19, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33213.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   LLM Linter (✨ experimental)

   Possible typos and grammar issues:

   • In util.cpp error message: “Verbosity was boolean but only integer allowed” -> “Verbosity was boolean but only integer values are allowed” [missing plural/verb for clarity]

   drahtbot_id_4_m

Contributors
fqlx DrahtBot

Labels
RPC/REST/ZMQ