rpc: require integer verbosity; remove boolean ‘verbose’ #33214

1. 
   fqlx commented at 2:56 am on August 19, 2025: none

   Summary

   Standardize RPC verbosity to integers only and remove boolean handling for clarity, consistency, and future extensibility.

   Rationale

   • Legacy cleanup: Boolean verbosity has been discouraged/deprecated in docs since 2017 and continues to create tech debt (special-case parsing, inconsistent tests, user confusion).
   • Consistency: Integers enable multi-level output without overloading a boolean.

   User-visible changes

   • getblock, getrawtransaction, getorphantxs no longer accept booleans.
   • Passing true/false now errors with: Verbosity was boolean but only integer allowed.
   • Migration: false → 0, true → 1.

   Code / Docs

   • ParseVerbosity(arg, default) now rejects booleans (removed allow_bool).
   • Call sites and functional tests updated to use integer levels.
   • Developer notes updated; release notes added.

   Breaking change: scripts/tools using boolean verbosity must switch to integers.

2. 
   DrahtBot commented at 2:56 am on August 19, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33214.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   Concept NACK	stickies-v

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #32468 (rpc: generateblock to allow multiple outputs by polespinasa)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

3. fqlx renamed this:
   Rpc no bool verbosity
   rpc: require integer verbosity; remove boolean 'verbose
   on Aug 19, 2025
4. DrahtBot added the label RPC/REST/ZMQ on Aug 19, 2025
5. fqlx renamed this:
   rpc: require integer verbosity; remove boolean 'verbose
   rpc: require integer verbosity; remove boolean 'verbose'
   on Aug 19, 2025
6. fqlx force-pushed on Aug 19, 2025
7. DrahtBot added the label CI failed on Aug 19, 2025
8. fqlx force-pushed on Aug 19, 2025
9. fqlx force-pushed on Aug 19, 2025
10. fqlx force-pushed on Aug 19, 2025
11. 
    stickies-v commented at 11:01 am on August 19, 2025: contributor

    Directionally, this is the right way to go, but I don’t think we should be breaking the API for just this change. Let’s do these cleanups when we can bundle them with other, necessary breaking changes, on a case-by-case basis. Concept NACK.
12. DrahtBot removed the label CI failed on Aug 19, 2025
13. fqlx force-pushed on Aug 19, 2025
14. rpc: require integer verbosity; drop boolean 'verbose'

    - Remove boolean handling from ParseVerbosity() and update callers.
    - getblock/getrawtransaction/getrawmempool no longer accept true/false.
    - Switch functional/Qt tests to integer verbosity.
    - Update release notes and docs.

    248ea17a60
15. fqlx force-pushed on Aug 19, 2025

Contributors
fqlx DrahtBot stickies-v

Labels
RPC/REST/ZMQ