Increase default -blockmaxsize/prioritysize to 750K/50K #3326

pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:blockmaxsize changing 2 files +6 −6
  1. gavinandresen commented at 11:15 am on November 28, 2013: contributor

    Proposed change for the 0.8.6 release: increase the default block size by to 750K, and free transaction area to 50K.

    There is a more conservative change in 0.8.6:

    1. Transaction confirmation times are rising as blocks fill up.
    2. It will be a good “natural experiment” to estimate what fraction of miners run with defaults.

    See https://gist.github.com/gavinandresen/7670433 for current thinking on how fee-handling will evolve over the next couple of releases.

  2. in src/main.h: in 07d34bc333 outdated
    34@@ -35,10 +35,14 @@
    35 
    36 /** The maximum allowed size for a serialized block, in bytes (network rule) */
    37 static const unsigned int MAX_BLOCK_SIZE = 1000000;
    38-/** The maximum size for mined blocks */
    39+/** Obsolete: maximum size for mined blocks */
    40 static const unsigned int MAX_BLOCK_SIZE_GEN = MAX_BLOCK_SIZE/2;
    


    laanwj commented at 11:26 am on November 28, 2013:
    There is no need to keep the obsolete MAX_BLOCK_SIZE_GEN in master as it’s used nowhere except for the occurence in miner which is removed in this pull.
  3. gavinandresen commented at 5:08 am on November 29, 2013: contributor
    Removed obsolete BLOCK_SIZE_GEN, as @laanwj suggested.
  4. mikehearn commented at 10:46 am on November 29, 2013: contributor

    Your description says increase by 100kb, but as far as I can tell it’s only a 50kb increase? Default was 250kb after this change it’s 300kb. Which was the intention?

    Luke-Jr runs with 1mb and BTC-Guild runs with 500 iiuc so it seems a 50kb bump may be too conservative given that we’re now routinely over 1 tx/sec:

    https://blockchain.info/charts/n-transactions

    At 100,000 txns/day (let’s be optimistic and hope that the new users stick around) that’s an average of ~695 transactions per block, at about 200 bytes average that’s 139kb. (does anyone have a graph of avg tx size?). So 300kb means the average block is about half that. But variance means blocks don’t come every 10 minutes, it’s pretty common to have to wait 20 or 30 minutes. Any time that happens the new soft limit will still be hit and the queue will start to back up/mempool will start to expand.

    It’d be nice to have a rule of thumb for block size vs average tx rate, but I guess if we say going an hour with no block is pretty common, but 2 hours isn’t, then soft block size should be 6x daily rate/144 so that when the network waits an hour to get a block, the backlog can still be cleared. That would imply 140*6=840kb at current traffic levels.

  5. Increase default -blockmaxsize/prioritysize to 750K/50K ad898b40aa
  6. gavinandresen commented at 4:41 am on November 30, 2013: contributor
    @mikehearn: good arguments. Changed to increase to 750K-big blocks; 0.8.6 still has the much more conservative change.
  7. BitcoinPullTester commented at 5:01 am on November 30, 2013: none
    Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ad898b40aaf06c1cc7ac12e953805720fc9217c0 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
  8. mikehearn commented at 10:13 am on November 30, 2013: contributor
    LGTM, only other improvement I can see is documenting the reason for the choice in the comments.
  9. jgarzik commented at 0:06 am on December 13, 2013: contributor
    ACK
  10. laanwj referenced this in commit 150771c4f3 on Dec 13, 2013
  11. laanwj merged this on Dec 13, 2013
  12. laanwj closed this on Dec 13, 2013

  13. gavinandresen deleted the branch on Mar 13, 2014
  14. MathyV referenced this in commit b6c72a6ccd on Aug 4, 2014
  15. MathyV referenced this in commit 617cebca05 on Aug 5, 2014
  16. Bushstar referenced this in commit dff9430c5e on Apr 8, 2020
  17. DrahtBot locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2024-11-21 21:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me