fix: Merkle root calculation #33262

pull zkpepe wants to merge 1 commits into bitcoin:master from zkpepe:patch-1 changing 1 files +8 −2

zkpepe commented at 5:05 pm on August 27, 2025: none

dropped the extra SHA256D64 call that was messing up the result. now it just builds the next level with Hash(a, b) like in Bitcoin Core, and the Merkle root comes out right.
fix: Merkle root calculation c72c1e697a
DrahtBot commented at 5:05 pm on August 27, 2025: contributor

The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

Code Coverage & Benchmarks

For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33262.

Reviews

See the guideline for information on the review process. A summary of reviews will appear here.
fanquake closed this on Aug 27, 2025
zkpepe deleted the branch on Aug 27, 2025
l0rinc commented at 5:28 pm on August 27, 2025: contributor

For the record, this is a similar attempt to #32497 (review) (probably used by an LLM for inspiration) - but the code was pushed from the GitHub UI and even included the code snipped markers. @zkpepe, if you want to help, this isn’t it, do the work instead of these cheap spams.