rpc: analyzepsbt should explicitly check for an invalid taproot_key_path_sig #33320

1. 
   Sjors commented at 12:37 pm on September 5, 2025: member

   While testing #29675 my final combined PSBT ended up having an invalid taproot_key_path_sig, which I found out by logging the sigdata.complete value at the end of ProduceSignature.

   We should of course never produce such an invalid value and I’ll continue digging for the root cause. But external applications could do this too.

   Currently analyzepsbt will give a useless "next": "updater" status when this happens.

   We should instead display an error.

   Not sure what the best approach would be.

2. 
   Sjors commented at 12:42 pm on September 5, 2025: member

   FWIW this particular situation happened because a ledger signed one of the script paths and my WIP branch for HWI ended up putting that signature in the key path.
3. fanquake added the label RPC/REST/ZMQ on Sep 5, 2025

Contributors
Sjors

Labels
RPC/REST/ZMQ