bench: broken CSV format, commas in benchmark names #33331

1. 
   Raimo33 commented at 2:31 pm on September 7, 2025: none

   Currently there are a couple of benchmarks that have commas in their name:

   • SHA256D64_1024_AVX2 using the ‘sse4(1way),sse41(4way),avx2(8way)’ SHA256 implementation
   • SHA256D64_1024_SHANI using the ‘sse4(1way),sse41(4way)’ SHA256 implementation
   • SHA256D64_1024_SSE4 using the ‘sse4(1way),sse41(4way)’ SHA256 implementation
   • SHA256D64_1024_STANDARD using the ‘standard’ SHA256 implementation
   • SHA256_32b_AVX2 using the ‘sse4(1way),sse41(4way),avx2(8way)’ SHA256 implementation
   • SHA256_32b_SHANI using the ‘sse4(1way),sse41(4way)’ SHA256 implementation
   • SHA256_32b_SSE4 using the ‘sse4(1way),sse41(4way)’ SHA256 implementation
   • SHA256_32b_STANDARD using the ‘standard’ SHA256 implementation
   • SHA256_AVX2 using the ‘sse4(1way),sse41(4way),avx2(8way)’ SHA256 implementation
   • SHA256_SHANI using the ‘sse4(1way),sse41(4way)’ SHA256 implementation
   • SHA256_SSE4 using the ‘sse4(1way),sse41(4way)’ SHA256 implementation
   • SHA256_STANDARD using the ‘standard’ SHA256 implementation

   This breaks the CSV format when using ./bench_bitcoin -output-csv=bench_old.csv. Commas are allowed only as column separators in CSV.

2. maflcko added the label Tests on Sep 7, 2025
3. bitcoin deleted a comment on Sep 8, 2025
4. fanquake closed this on Sep 9, 2025

   ---

5. fanquake referenced this in commit 9cbd346daa on Sep 9, 2025

Contributors
Raimo33

Labels
Tests