contrib: Add bash completion for new bitcoin command #33385

1. 
   caesrcd commented at 3:34 pm on September 13, 2025: none

   Adds a bash completion script for the new bitcoin command-line tool (introduced in #31375), which unifies the main Bitcoin Core executables under a single interface. This feature improves usability, reduces errors, and makes the command-line tools more easily discoverable for users working in a Linux bash environment.

   The completion script dynamically lists available commands and options by parsing bitcoin --help and bitcoin help. It also incorporates the existing bash completions for bitcoind, bitcoin-cli, and bitcoin-tx, depending on the argument provided (node, rpc, or tx). This ensures that all relevant completions are available seamlessly through a single interface without modifying core functionality.

   Key points:

   • Improves developer and user experience on the command line.
   • Does not modify or replace existing functionality.
   • Placed under contrib/ for easy installation by users and distributions.
2. DrahtBot added the label Scripts and tools on Sep 13, 2025
3. DrahtBot closed this on Sep 13, 2025

   ---

4. 
   DrahtBot commented at 3:34 pm on September 13, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33385.

   Reviews

   See the guideline for information on the review process.

   Type	Reviewers
   ACK	epcgrs

   If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

   Conflicts

   Reviewers, this pull request conflicts with the following ones:

   • #33747 (feat: shell completions for bitcoin wrapper executable by hulxv)

   If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

   LLM Linter (✨ experimental)

   Possible typos and grammar issues:

   • senseful -> sensible [nonstandard word “senseful” should be “sensible” to be clear]
   • save and use original argument -> save and use the original argument [missing “the” makes the phrase slightly ungrammatical]

   drahtbot_id_5_m

5. fanquake reopened this on Sep 13, 2025

   ---

6. contrib: Add bash completion for new bitcoin command

   Adds a bash completion script for the new bitcoin command-line
   tool, which unifies the main Bitcoin Core executables under a
   single interface. This feature improves usability, reduces errors,
   and makes the command-line tools more easily discoverable for users
   working in a Linux bash environment.
   
   The completion script dynamically lists available commands and options
   by parsing `bitcoin --help` and `bitcoin help`. It also incorporates
   the existing bash completions for `bitcoind`, `bitcoin-cli`, and
   `bitcoin-tx`, depending on the argument provided (node, rpc, or tx).
   This ensures that all relevant completions are available seamlessly
   through a single interface without modifying core functionality.
   
   No functional changes to core code are introduced; this is an optional
   enhancement placed under `contrib/` for easy installation and use.

   b5d45f0601
7. caesrcd force-pushed on Sep 14, 2025
8. bitcoin deleted a comment on Sep 15, 2025
9. caesrcd renamed this:
   contrib: add bash completion for new bitcoin command
   contrib: Add bash completion for new bitcoin command
   on Sep 16, 2025
10. 
    epcgrs commented at 2:43 am on September 19, 2025: none

    utACK b5d45f0

    • Well structured;
    • Good practices with bash scripting;
    • Dynamic search using help;

    LGTM

11. 
    epcgrs commented at 8:10 pm on October 11, 2025: none

    ACK b5d45f0

12. 
    prusnak commented at 6:51 am on October 13, 2025: contributor

    ISTM “bitcoin test” is not covered
13. 
    caesrcd commented at 11:56 am on October 13, 2025: none

    @prusnak It will complete the arguments of bitcoin itself and the subarguments of commands that already have their own completion.

    To cover bitcoin test, a completion script for the test_bitcoin command would need to be created.

Contributors
caesrcd DrahtBot epcgrs prusnak

Labels
Scripts and tools