...that was not necessary, as the field still receives focus without it.
Fix a rare crash on Mac OS X, by removing a setFocus on the payTo field ... #3339
pull ryan52 wants to merge 1 commits into bitcoin:master from ryan52:master changing 1 files +0 −2-
ryan52 commented at 4:35 AM on December 2, 2013: contributor
-
Fix a rare crash on Mac OS X, by removing a setFocus on the payTo field that was not necessary, as the field still receives focus without it. bae6c7e32b
-
ryan52 commented at 4:45 AM on December 2, 2013: contributor
This crash has been described by Warren on the bitcoin-development mailing list: http://sourceforge.net/mailarchive/forum.php?thread_name=CAEz79PptC4VZr19iHYx5iA2K8SZ2aJbUvnt8_ZGRwbBJ6%3DWW3A%40mail.gmail.com&forum_name=bitcoin-development
It is unknown if this race condition is problematic in bitcoin HEAD, but laanwj said it isn't needed there, it doesn't seem to help, so seems prudent to remove it.
I also have verified that in the various places the clear method is called, payTo receives focus in another way.
-
BitcoinPullTester commented at 5:08 AM on December 2, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/bae6c7e32bdbd867169c3e5489332a844a35eb7a for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
- laanwj referenced this in commit b9988c9e74 on Dec 2, 2013
- laanwj merged this on Dec 2, 2013
- laanwj closed this on Dec 2, 2013
-
wtogami commented at 10:13 AM on December 2, 2013: contributor
http://pastebin.com/N063nqrn It turns out to crash in another setfocus() ...
-
wtogami commented at 11:50 AM on December 2, 2013: contributor
@toffoo http://download1.rpmfusion.org/~warren/bitcoin-0.8.5-OMG7/macosx/ Please test Bitcoin-Qt-0.8.5-OMG7-no-mmap2.dmg. I included yet another "remove setFocus()" at the recommendation of @laanwj.
- DrahtBot locked this on Sep 8, 2021
Contributors