coin-grinder missing test for TOTAL_TRIES #33419

The following (mutation) code can be remove from coin-grinder here without encountering a test failure

if (curr_try >= TOTAL_TRIES) {
    // Solution is not guaranteed to be optimal if `curr_try` hit TOTAL_TRIES
    result.SetAlgoCompleted(false);
    break;
}

This ought to be a similar test to Test BnB attempt limit (TOTAL_TRIES)

cc @murchandamus

For reference: https://corecheck.dev/mutation/src/wallet/coinselection.cpp#L466 and https://corecheck.dev/mutation/src/wallet/coinselection.cpp#L468

Yeah, it would be good to add this test. If someone wants to work on this, I would like to suggest that they peruse the very similar test for BnB here: https://github.com/bitcoin/bitcoin/blob/e744fd1249bf9577274614eaf3997bf4bbb612ff/src/wallet/test/coinselection_tests.cpp#L166 And to understand what CoinGrinder is actually doing and how it work, I would suggest that prospective implementers peruse the PR that added CoinGrinder starting with this commit: https://github.com/bitcoin/bitcoin/pull/27877/commits/6cc9a46cd0f4ed80d4523bbef1508142e0c80d27

Something like this would work:

    {
        // #################################################################################################################
        // 8) Max iterations
        // #################################################################################################################
        CAmount target =  8 * COIN;
        int max_selection_weight = 3200; // WU
        const auto& res = CoinGrinder(target, dummy_params, m_node, max_selection_weight, [&](CWallet& wallet) {
            CoinsResult doppelgangers;
            for (int i = 0; i < 19; ++i) {
                add_coin(doppelgangers, wallet, CAmount(1 * COIN + i), CFeeRate(0), 144, false, 0, true, 96 + i);
            } 
            return doppelgangers;
        });
        BOOST_CHECK(!res);
    }