Bugfix: QA: rpc_bind: Skip nonloopback test if no such address is found #33433

pull luke-jr wants to merge 1 commits into bitcoin:master from luke-jr:qafix_rpc_bind_nonloopback_unavail changing 1 files +4 −1
  1. luke-jr commented at 3:15 am on September 19, 2025: member

    Without this, I get:

     02025-09-19T03:14:05.157000Z TestFramework (INFO): PRNG seed is: 3218602557639511064
     12025-09-19T03:14:05.158000Z TestFramework (INFO): Initializing test directory /tmp/bitcoin-test/a
     22025-09-19T03:14:05.158000Z TestFramework (INFO): Check for ipv6
     32025-09-19T03:14:05.158000Z TestFramework (INFO): Check for non-loopback interface
     42025-09-19T03:14:05.158000Z TestFramework (INFO): Bind test for []
     52025-09-19T03:14:05.516000Z TestFramework (INFO): Bind test for []
     62025-09-19T03:14:05.871000Z TestFramework (INFO): Bind test for ['[::1]']
     72025-09-19T03:14:06.227000Z TestFramework (INFO): Bind test for ['127.0.0.1', '[::1]']
     82025-09-19T03:14:06.583000Z TestFramework (INFO): Using interface None for testing
     92025-09-19T03:14:06.583000Z TestFramework (INFO): Bind test for [None]
    102025-09-19T03:14:06.583000Z TestFramework (ERROR): Unexpected exception
    11Traceback (most recent call last):
    12  File "/Bitcoin/bitcoin/workingtree/test/functional/test_framework/test_framework.py", line 135, in main
    13    self.run_test()
    14    ~~~~~~~~~~~~~^^
    15  File "/Bitcoin/bitcoin/workingtree/test/functional/rpc_bind.py", line 126, in run_test
    16    self._run_nonloopback_tests()
    17    ~~~~~~~~~~~~~~~~~~~~~~~~~~~^^
    18  File "/Bitcoin/bitcoin/workingtree/test/functional/rpc_bind.py", line 157, in _run_nonloopback_tests
    19    self.run_bind_test([self.non_loopback_ip], self.non_loopback_ip, [self.non_loopback_ip],
    20    ~~~~~~~~~~~~~~~~~~^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    21        [(self.non_loopback_ip, self.defaultport)])
    22        ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    23  File "/Bitcoin/bitcoin/workingtree/test/functional/rpc_bind.py", line 38, in run_bind_test
    24    expected = [(addr_to_hex(addr), port) for (addr, port) in expected]
    25                 ~~~~~~~~~~~^^^^^^
    26  File "/Bitcoin/bitcoin/workingtree/test/functional/test_framework/netutil.py", line 132, in addr_to_hex
    27    if '.' in addr: # IPv4
    28       ^^^^^^^^^^^
    29TypeError: argument of type 'NoneType' is not iterable
    
  2. Bugfix: QA: rpc_bind: Skip nonloopback test if no such address is found 79b4c276e7
  3. DrahtBot commented at 3:15 am on September 19, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33433.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-09-26 15:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me