Fix file hash verification error in deps-win32.yml #3345

pull Michagogo wants to merge 1 commits into bitcoin:master from Michagogo:gitian-descriptor-deps-input-typo changing 1 files +1 −1

Michagogo commented at 12:05 AM on December 3, 2013: contributor

libpng was being sha256summed twice, and miniupnpc wasn't being checked at all.

Fix file hash verification error in deps-win32.yml

libpng was being sha256summed twice, and miniupnpc wasn't being checked at all.

c51e49b1a3

BitcoinPullTester commented at 12:42 AM on December 3, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c51e49b1a367b328c8567f908b7b5c28263d0bb5 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
wtogami commented at 6:43 AM on December 3, 2013: contributor

Matches what I have for miniupnpc-1.6.tar.gz.

ACK
gavinandresen referenced this in commit 0563ee952c on Dec 3, 2013
gavinandresen merged this on Dec 3, 2013
gavinandresen closed this on Dec 3, 2013
laanwj commented at 7:04 AM on December 3, 2013: member

I still think we should get rid of the libpng here some day, as its entirely not used. (that was my point with #3343, with building libqrencode with --without-tools)
wtogami commented at 10:06 AM on December 3, 2013: contributor

+1 to @laanwj
Michagogo deleted the branch on Dec 3, 2013
sipa commented at 12:19 PM on December 3, 2013: member

How does Qt show png files, if not through libpng?
laanwj commented at 12:45 PM on December 3, 2013: member
The "qt everywhere" download that we use has its own libz, libpng, libjpeg, libmng (and some other qt-specific third party dependencies) built-in. It only uses an external OpenSSL at the moment.

I just checked:
- Qt 4.8.3 (current) has libpng 1.5.10 included, which is newer than our 1.5.9.
- Qt 4.8.5 (newest 4.x) has the same
- Qt 5.1.1 (newest 5.x) has the same
Blegh, it's still an old version... does anyone know what is the first version that fixes the security bug?
sipa commented at 1:11 PM on December 3, 2013: member

1.5.10 fixes it.
Bushstar referenced this in commit b188c5c25e on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors