- Description:
- What: Use stricter curl flags when fetching ShellCheck and MLC in
ci/lint/01_install.sh. - Why: Prevent silent installs on HTTP errors and disallow non-HTTPS protocols, improving supply-chain safety.
- Changes:
- Replace
-sLwith--fail --location --proto '=https' --tlsv1.2 --silent --show-errorfor both downloads.
- Replace
- Impact: CI now fails explicitly on 4xx/5xx and protocol downgrades; no behavioral changes otherwise.
- What: Use stricter curl flags when fetching ShellCheck and MLC in
ci(lint): Harden curl usage in 01_install.sh with fail-safe flags #33456
pull viktorking7 wants to merge 1 commits into bitcoin:master from viktorking7:master changing 1 files +2 −2-
viktorking7 commented at 2:49 PM on September 22, 2025: none
-
Update 01_install.sh 59365d61de
-
DrahtBot commented at 2:49 PM on September 22, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33456.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
LLM Linter (✨ experimental)
Possible typos and grammar issues:
- url -> curl [invalid command name; should be 'curl' to download from the URL]
<sup>drahtbot_id_5_m</sup>
-
maflcko commented at 3:08 PM on September 22, 2025: member
Thanks, but closing for now:
- The patch is obviously wrong, as can be seen by the failing CI and the LLM linter.
- https does not add any meaningful supply-chain safety here for GitHub release downloads, so the benefit is unclear.
- If supply-chain safety was needed, it would be better to pin by a hash or commit id (and compile from source).
Adding
--failseems fine, but I doubt it matters much in practise. Also, there are plenty of other places where it should be added for consistency, if it was added here. - maflcko closed this on Sep 22, 2025
Contributors