[Qt] small notificator and style changes #3348

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:Qt-misc changing 9 files +14 −13

Diapolo commented at 8:28 AM on December 3, 2013: none
- remove default arguments for notificator
- re-order some calls to use same ordering in Qt files
- style police changes (spaces, comments and such)
Mostly no code changes, should be easy to merge.
in src/qt/clientmodel.h:None in 9d650cecc3 outdated
```
  83 | @@ -84,7 +84,7 @@ class ClientModel : public QObject
  84 |      void alertsChanged(const QString &warnings);
  85 |      void bytesChanged(quint64 totalBytesIn, quint64 totalBytesOut);
  86 |  
  87 | -    //! Asynchronous message notification
  88 | +    // Fired when a message should be reported to the user
```
laanwj commented at 11:41 AM on December 3, 2013:

If you don't like //!, please use /// instead (see http://www.stack.nl/~dimitri/doxygen/manual/docblocks.html)

Diapolo commented at 12:31 PM on December 3, 2013:

I really just tried to use the same comment for this as we use in other source files :).

laanwj commented at 12:46 PM on December 3, 2013:

I understand, but // is not enough to make doxygen see it as a function documentation.
laanwj commented at 11:42 AM on December 3, 2013: member

ACK apart from minor nit

[Qt] small notificator and style changes

- remove default arguments for notificator
- re-order some calls to use same ordering in Qt files
- style police changes (spaces, comments and such)

ccd1372dd0

Diapolo commented at 1:02 PM on December 3, 2013: none

@laanwj Should be fine now :).
BitcoinPullTester commented at 1:32 PM on December 3, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/ccd1372dd063e4098a245da91c9e73743484f68a for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 70370ae502 on Dec 8, 2013
laanwj merged this on Dec 8, 2013
laanwj closed this on Dec 8, 2013
Diapolo deleted the branch on Dec 9, 2013
Bushstar referenced this in commit 2521970a50 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors