par value can spawn up to 15 script verification threads for each node. Running the functional test suite with default par can exhaust file descriptors or hit other resource limits when many threads are spawned. These threads are mostly idle and the same code paths are executed with a value of par=2. Limit this to 2 for functional tests that do not override the default option.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33485.
See the guideline for information on the review process.
| Type | Reviewers |
|---|---|
| ACK | pablomartin4btc, l0rinc, maflcko, theStack |
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
473@@ -474,6 +474,7 @@ def write_config(config_path, *, n, chain, extra_config="", disable_autoconnect=
474 # min_required_fds = MIN_CORE_FDS + MAX_ADDNODE_CONNECTIONS + nBind = 151 + 8 + 3 = 162;
475 # nMaxConnections = available_fds - min_required_fds = 256 - 161 = 94;
476 f.write("maxconnections=94\n")
477+ f.write("par=2\n")
min(2, os.cpu_count()) to avoid forcing a second thread when only one core is available.
Depending on the host machine, a default `par` value can spawn up to 15 script verification threads for each node.
Running the functional test suite with default `par` can exhaust file descriptors or hit other resource limits when many threads are spawned.
These threads are mostly idle and the same code paths are executed with a value of `par=2`.
Limit this to 2 for functional tests that do not override the default option.
Co-authored-by: maflcko <6399679+maflcko@users.noreply.github.com>
ACK dda5228e02ca6a839bf87ae7dbd133547563816a
I thought some of the top longest tests would require a diff (>) par=, but it looks alright.
Code review ACK dda5228e02ca6a839bf87ae7dbd133547563816a
Q: does this affect the "-par=1" cases in https://github.com/bitcoin/bitcoin/blob/9a04635432183c437829339dbf10e7d702581010/test/functional/p2p_segwit.py#L221 and https://github.com/bitcoin/bitcoin/blob/6980852416040bdddf111df3cea3ec50639f010a/test/functional/feature_proxy.py#L385?
Q: does this affect the “-par=1” cases
No, extra args override args in the configuration file.
