Address Book related Fixes #335

pull sgimenez wants to merge 7 commits into bitcoin:master from sgimenez:master changing 5 files +87 −24

sgimenez commented at 9:43 PM on June 20, 2011: contributor

Add a check for validity of sending addresses (Issue #328). Fix the behaviour of setaccount on sending addresses that are already listed in the Address Book. (Issue #329). This also fixes the syncrhonization of sending addresses between a CWallet and its associated CWalletDB, and avoids unnecessary CWalletDB updates.

This is my first commit. It is quite small, but please review it in details before the pull. Thanks.

Add a check for validity of sending addresses (Issue #328).

This also fixes the syncrhonization of sending addresses between a
CWallet and its associated CWalletDB.

551a4ef372

Allow Address Book edition in non-file backed CWallets bb18958efe
sgimenez commented at 11:40 AM on June 21, 2011: contributor
Mmm, some calls to {Set,Del}AddressBookName were wraped in a
```
CRITICAL_BLOCK(pwalletMain->cs_mapAddressBook)
```
and some were not. Now, all of them should be, since map operations are not guaranteed to be atomic. Correct me if I'm wrong.

Also, calls to CWalletDB(...).{Write,Erase}Name could be avoided in the case data would be be unmodified. Any problems with that?
Update critical sections for Address Book editions f2b6b0747c
Avoid propagation of unnecessary updates to CWalletDB eca796bee4
Fix for setaccount related Issue #329 6d7de046e4
Extract Address Book code from wallet.h to wallet.cpp fe927d5cb0
Add wallet methods GetDefaultAddress, SetDefaultAddress 1d4341bbdb
sgimenez commented at 9:35 PM on June 27, 2011: contributor

I've added contribution from laanwj in Issue #350.

A rebased and cleaned series of patches is available in sgimenez:addressbookfixes branch. Should I set up a new pull request and close this one?
sgimenez closed this on Jun 27, 2011
zathras-crypto referenced this in commit fe663602f0 on Jan 29, 2016
deadalnix referenced this in commit 622f47f778 on Mar 25, 2017
ptschip referenced this in commit a086fd19b2 on Apr 24, 2017
classesjack referenced this in commit 05420183ef on Jan 2, 2018
attilaaf referenced this in commit 5bc22bf189 on Jan 13, 2020
rajarshimaitra referenced this in commit 537a502072 on Aug 5, 2021
DrahtBot locked this on Sep 8, 2021

Contributors

sgimenez

Linked (view graph)

#328 Validity of sending addresses in the Address Book.#329 Using setaccount on addresses that are already listed in the Address Book.#358 Address Book related Fixes