BIP 72 was changed to save six bytes in bitcoin: URIs.
I updated the Handy Dandy Payment Request Generator page at https://bitcoincore.org/~gavin/createpaymentrequest.php and run a couple of -testnet tests.
Payment request URI syntax changed, from request=... to r=... #3353
pull gavinandresen wants to merge 1 commits into bitcoin:master from gavinandresen:payrequestURI changing 2 files +3 −3-
gavinandresen commented at 4:14 AM on December 4, 2013: contributor
-
1e01f7c506
Payment request URI syntax changed, from request=... to r=...
BIP 72 was changed to save six bytes in bitcoin: URIs.
-
BitcoinPullTester commented at 4:47 AM on December 4, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/1e01f7c506af60012bb99ced053d98eb529eda61 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
laanwj commented at 10:35 AM on December 4, 2013: member
I'm ok with the change. But shouldn't we remain compatible with the request= syntax, in case people have started using that? Or is it still early enough?
-
Diapolo commented at 7:56 AM on December 5, 2013: none
No problem with it either...
-
laanwj commented at 10:21 AM on December 5, 2013: member
We should also update the BIP here https://github.com/bitcoin/bips/blob/master/bip-0072.mediawiki
-
sipa commented at 12:41 PM on December 5, 2013: member
If we intend the bips repo to be the autoritative source of BIPs, the pages on the wiki should at least be made read-only, and ideally just links to the corresponding files in the bips repository.
That may warrant some morediscussion on the mailinglist first, though.
-
laanwj commented at 1:05 PM on December 5, 2013: member
The original discussion on the mailing list that led to creation of the repository was here:
- laanwj referenced this in commit b4297c8fff on Dec 6, 2013
- laanwj merged this on Dec 6, 2013
- laanwj closed this on Dec 6, 2013
- gavinandresen deleted the branch on Mar 13, 2014
- Bushstar referenced this in commit 6c319e139f on Apr 8, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors