Use deleteLater() instead of delete, as it is not allowed to delete widgets directly in an event handler. Should solve the MacOSX random crashes on send with coincontrol.
qt: use deleteLater to remove send entries #3355
pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_12_deletelater_send changing 1 files +2 −2-
laanwj commented at 7:26 AM on December 4, 2013: member
-
6c98cca9e4
qt: use deleteLater to remove send entries
Use deleteLater() instead of delete, as it is not allowed to delete widgets directly in an event handler. Should solve the MacOSX random crashes on send with coincontrol.
-
BitcoinPullTester commented at 7:40 AM on December 4, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/6c98cca9e47ddb9c786cd3f0445175c378515e0d for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
-
gavinandresen commented at 7:54 AM on December 4, 2013: contributor
ACK (untested, but changes look trivial and good).
-
laanwj commented at 8:38 AM on December 4, 2013: member
It appears that this does change a little bit of behavior: it's now possible to delete the last recipient. This is harmless: send will do nothing, and it's possible to add it again. But to keep the same behavior I need to re-think this a bit.
-
laanwj commented at 8:40 AM on December 4, 2013: member
Ignore that: that was already the case without this patch. Phew.
- laanwj referenced this in commit 00cfc9f074 on Dec 4, 2013
- laanwj merged this on Dec 4, 2013
- laanwj closed this on Dec 4, 2013
- laanwj deleted the branch on Apr 9, 2014
- Bushstar referenced this in commit 05c134c783 on Apr 8, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors