ci: Use native platform for win-cross task #33558

pull maflcko wants to merge 1 commits into bitcoin:master from maflcko:2510-native-win-cross changing 1 files +0 −1
  1. maflcko commented at 10:32 am on October 7, 2025: member

    Forcing the architecture to amd64 is no longer required. Dropping it should have some benefits:

    • Faster CI speed on other arches (riscv64, arm, …)
    • Unlock the CI task to run on riscv64 at all
  2. ci: Use native platform for win-cross task fa6fd16f36
  3. DrahtBot added the label Tests on Oct 7, 2025
  4. DrahtBot commented at 10:32 am on October 7, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33558.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK hebasto

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  5. hebasto commented at 11:28 am on October 7, 2025: member

    Tested fa6fd16f36e1240cda58a46e1717b02e8d3172a3:

     0$ uname -mo
     1riscv64 GNU/Linux
     2$ docker --version
     3podman version 4.3.1
     4$ env -i HOME="$HOME" PATH="$PATH" USER="$USER" bash -c 'MAKEJOBS="-j3" FILE_ENV="./ci/test/00_setup_env_win64.sh" ./ci/test_run_all.sh'
     5<snip>
     6+ echo 'Creating mirror.gcr.io/ubuntu:24.04 container to run in'
     7Creating mirror.gcr.io/ubuntu:24.04 container to run in
     8+ docker buildx build --file /home/hebasto/dev/bitcoin/ci/test_imagefile --build-arg CI_IMAGE_NAME_TAG=mirror.gcr.io/ubuntu:24.04 --build-arg FILE_ENV=./ci/test/00_setup_env_win64.sh --build-arg BASE_ROOT_DIR=/ci_container_base --platform=linux --label=bitcoin-ci-test --tag=ci_win64 /home/hebasto/dev/bitcoin
     9Error: invalid platform syntax for "linux" (use OS/ARCH[/VARIANT][,...])
    10Command '['./ci/test/02_run_container.sh']' returned non-zero exit status 125.
    
  6. maflcko commented at 11:56 am on October 7, 2025: member

    Error: invalid platform syntax for “linux” (use OS/ARCH[/VARIANT][,…])

    thanks for testing. However, this looks like an unrelated issue with your podman version. I presume you can’t run any native task at all. My recommendation would be to upgrade your os (or podman) to the latest stable version.

  7. hebasto commented at 3:42 pm on October 12, 2025: member
    • Unlock the CI task to run on riscv64 at all

    Isn’t this relevant to other tasks as well, for example, ci/test/00_setup_env_arm.sh?

  8. hebasto approved
  9. hebasto commented at 4:12 pm on October 12, 2025: member
    ACK fa6fd16f36e1240cda58a46e1717b02e8d3172a3, tested on Ubuntu 24.04, RISC-V.
  10. maflcko commented at 6:55 am on October 13, 2025: member
    • Unlock the CI task to run on riscv64 at all

    Isn’t this relevant to other tasks as well, for example, ci/test/00_setup_env_arm.sh?

    That task requires the aarch64 architecture and is not a native task. Not sure if it matters much if qemu-aarch64 is running on x86 or riscv, but feel free to open a separate issue or pull request. The goal here is mainly to speed up the win-cross task for non-x86 arches. Being able to run it on riscv64 is a nice cherry on top.

  11. fanquake merged this on Oct 13, 2025
  12. fanquake closed this on Oct 13, 2025

  13. maflcko deleted the branch on Oct 13, 2025
  14. fanquake referenced this in commit 20e99515a3 on Oct 13, 2025
  15. bitcoin deleted a comment on Oct 13, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-06 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me