doc: bump the template macOS version #33573

pull kevkevinpal wants to merge 1 commits into bitcoin:master from kevkevinpal:bumpIssueTemplateMacOSVersion changing 1 files +1 −2
  1. kevkevinpal commented at 3:03 pm on October 8, 2025: contributor

    Motivated by #33489 (comment)

    The minimum version of MacOS for this repo is now 14 and above so it makes sense to update the issue template to reflect that. We are now using a higher version but since it is just a bug template, there is no need to put the lowest version we support.

  2. DrahtBot added the label Docs on Oct 8, 2025
  3. DrahtBot commented at 3:03 pm on October 8, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33573.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, l0rinc, janb84

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. janb84 commented at 3:12 pm on October 8, 2025: contributor
    The v30 has still support for 13+. see #33559 (review)` Think it’s still to early to change this if v30 has still full support for that version.
  5. kevkevinpal commented at 3:42 pm on October 8, 2025: contributor

    The v30 has still support for 13+. see https://github.com/bitcoin/bitcoin/pull/33559#discussion_r2414194987` Think it’s still to early to change this if v30 has still full support for that version.

    I don’t think this change will be part of v30, so it should still be good for review

  6. glozow commented at 4:10 pm on October 8, 2025: member

    The v30 has still support for 13+. see https://github.com/bitcoin/bitcoin/pull/33559#discussion_r2414194987` Think it’s still to early to change this if v30 has still full support for that version.

    Note that this PR is against master, not 30.x

  7. l0rinc commented at 4:23 pm on October 8, 2025: contributor
    ACK 1dcff2e335444d5518961cdf798d9d24c6e3e1d7 Originally reported in #33489#pullrequestreview-3294934753
  8. janb84 commented at 6:35 pm on October 8, 2025: contributor

    The v30 has still support for 13+. see https://github.com/bitcoin/bitcoin/pull/33559#discussion_r2414194987` Think it’s still to early to change this if v30 has still full support for that version.

    Note that this PR is against master, not 30.x

    I get it. but it’s changing .github issue templates. Github uses master as a base for the templates right ? So V30 or not when it merges it will use this template as a base. Or is it set by hand by the maintainers ?

    (either way it’s not a big deal because it’s merely a suggestion and not a pull-down or something)

  9. glozow commented at 6:54 pm on October 8, 2025: member

    I get it. but it’s changing .github issue templates. Github uses master as a base for the templates right ?

    Oh sorry I misunderstood, you’re absolutely right. I think it’s more likely for people to use v30 on something more modern though.

  10. in .github/ISSUE_TEMPLATE/bug.yml:81 in 1dcff2e335
    77@@ -78,7 +78,7 @@ body:
    78     id: os
    79     attributes:
    80       label: Operating system and version
    81-      placeholder: e.g. "MacOS Ventura 13.2" or "Ubuntu 22.04 LTS"
    82+      placeholder: e.g. "MacOS Sonoma 14.0" or "Ubuntu 22.04 LTS"
    


    maflcko commented at 10:01 am on October 9, 2025:
    0      placeholder: e.g. "MacOS  26.0" or "Ubuntu 26.04 LTS"
    

    nit: Those are just placeholders, so the value doesn’t really matter. Though, if updating them, it may be best to update them in such a way that they won’t need to be touched again for the longest time.

    I understand that Ubuntu 26.04 doesn’t exist yet, but there will be a daily ISO starting next month, which seems good enough.


    l0rinc commented at 12:42 pm on October 9, 2025:
    +1 (except the double space in the suggestion)

    kevkevinpal commented at 3:59 pm on October 10, 2025:
    I’ve updated to use these newer versions in c80bcfb
  11. kevkevinpal force-pushed on Oct 10, 2025
  12. doc: bump the template macOS version
    It makes more sense to have a higher OS version than one that is not
    supported
    f6567527d8
  13. kevkevinpal force-pushed on Oct 10, 2025
  14. maflcko commented at 6:50 pm on October 10, 2025: member
    lgtm ACK f6567527d8dafa70335de782511791165bb89ccb
  15. DrahtBot requested review from l0rinc on Oct 10, 2025
  16. l0rinc commented at 7:07 pm on October 10, 2025: contributor

    ACK f6567527d8dafa70335de782511791165bb89ccb

    The Ubuntu version is a bit far into the future, but I don’t mind

  17. janb84 commented at 7:11 pm on October 10, 2025: contributor

    ACK f6567527d8dafa70335de782511791165bb89ccb

    With just recent references there is no discussion anymore if it is supported or not. Just examples of what someone can fill in.

  18. fanquake renamed this:
    doc: bump the template macOS version since 14 is now the minimum supported version
    doc: bump the template macOS version
    on Oct 10, 2025
  19. fanquake merged this on Oct 10, 2025
  20. fanquake closed this on Oct 10, 2025

  21. in .github/ISSUE_TEMPLATE/bug.yml:81 in f6567527d8
    77@@ -78,7 +78,7 @@ body:
    78     id: os
    79     attributes:
    80       label: Operating system and version
    81-      placeholder: e.g. "MacOS Ventura 13.2" or "Ubuntu 22.04 LTS"
    82+      placeholder: e.g. "MacOS 26.0" or "Ubuntu 26.04 LTS"
    


    ROLANDSIHOMBING1 commented at 2:58 am on October 13, 2025:
    •  placeholder : e.g." MacOS 26.0 " or
      

    “Ubuntu 26.05 LTS”

  22. ROLANDSIHOMBING1 commented at 2:59 am on October 13, 2025: none
    Create

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-31 18:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me