Motivated by #33489 (comment)
The minimum version of MacOS for this repo is now 14 and above so it makes sense to update the issue template to reflect that. We are now using a higher version but since it is just a bug template, there is no need to put the lowest version we support.
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33573.
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
The v30 has still support for 13+. see https://github.com/bitcoin/bitcoin/pull/33559#discussion_r2414194987` Think it’s still to early to change this if v30 has still full support for that version.
I don’t think this change will be part of v30, so it should still be good for review
The v30 has still support for 13+. see https://github.com/bitcoin/bitcoin/pull/33559#discussion_r2414194987` Think it’s still to early to change this if v30 has still full support for that version.
Note that this PR is against master, not 30.x
The v30 has still support for 13+. see https://github.com/bitcoin/bitcoin/pull/33559#discussion_r2414194987` Think it’s still to early to change this if v30 has still full support for that version.
Note that this PR is against master, not 30.x
I get it. but it’s changing .github issue templates. Github uses master as a base for the templates right ? So V30 or not when it merges it will use this template as a base. Or is it set by hand by the maintainers ?
(either way it’s not a big deal because it’s merely a suggestion and not a pull-down or something)
I get it. but it’s changing .github issue templates. Github uses master as a base for the templates right ?
Oh sorry I misunderstood, you’re absolutely right. I think it’s more likely for people to use v30 on something more modern though.
77@@ -78,7 +78,7 @@ body:
78 id: os
79 attributes:
80 label: Operating system and version
81- placeholder: e.g. "MacOS Ventura 13.2" or "Ubuntu 22.04 LTS"
82+ placeholder: e.g. "MacOS Sonoma 14.0" or "Ubuntu 22.04 LTS"
0 placeholder: e.g. "MacOS 26.0" or "Ubuntu 26.04 LTS"
nit: Those are just placeholders, so the value doesn’t really matter. Though, if updating them, it may be best to update them in such a way that they won’t need to be touched again for the longest time.
I understand that Ubuntu 26.04 doesn’t exist yet, but there will be a daily ISO starting next month, which seems good enough.
It makes more sense to have a higher OS version than one that is not
supported
ACK f6567527d8dafa70335de782511791165bb89ccb
The Ubuntu version is a bit far into the future, but I don’t mind
ACK f6567527d8dafa70335de782511791165bb89ccb
With just recent references there is no discussion anymore if it is supported or not. Just examples of what someone can fill in.
77@@ -78,7 +78,7 @@ body:
78 id: os
79 attributes:
80 label: Operating system and version
81- placeholder: e.g. "MacOS Ventura 13.2" or "Ubuntu 22.04 LTS"
82+ placeholder: e.g. "MacOS 26.0" or "Ubuntu 26.04 LTS"
placeholder : e.g." MacOS 26.0 " or
“Ubuntu 26.05 LTS”