leveldb: Use native Darwin memory barriers #3360

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_12_osx_memory_barrier changing 1 files +8 −8

laanwj commented at 8:22 AM on December 5, 2013: member

This prevents memory barriers from being optimized away on some compilers on OSX. May fix a cause of leveldb corruption issues.

See cfield's forum post: https://bitcointalk.org/index.php?topic=337294.msg3714808#msg3714808
leveldb: Use native Darwin memory barriers fc2ee333b2
BitcoinPullTester commented at 9:19 AM on December 5, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/fc2ee333b25e77b85defea6f54156f71d752415f for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj commented at 4:00 PM on December 11, 2013: member

There seems to be no need to merge this if we upgrade leveldb to 1.15

http://code.google.com/p/leveldb/downloads/detail?name=leveldb-1.15.0.tar.gz&can=2&q=
sipa commented at 5:30 PM on December 11, 2013: member

I'll update the bitcoin-leveldb repo to 1.15 soon, and PR it here.
sipa commented at 9:29 PM on December 12, 2013: member

Included in #3405.
jgarzik commented at 12:02 AM on December 13, 2013: contributor

Superceded by #3405
jgarzik closed this on Dec 13, 2013
Bushstar referenced this in commit 7334888122 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors