Remove remaining mention of datacarriersize being deprecated #33605

issue gmart7t2 opened this issue on October 13, 2025
  1. gmart7t2 commented at 12:12 AM on October 13, 2025: none

    #33453 undeprecated the datacarrier settings, but https://github.com/bitcoin/bitcoin/blob/v30.0/src/qt/bitcoinstrings.cpp#L165 still says:

    QT_TRANSLATE_NOOP("bitcoin-core", "Options '-datacarrier' or '-datacarriersize' are set but are marked as deprecated. They will be removed in a future version."),

    Best to remove that too?

  2. l0rinc commented at 12:14 AM on October 13, 2025: contributor

    this will be removed automatically

  3. hebasto commented at 10:22 AM on October 13, 2025: member

    Best to remove that too?

    https://github.com/bitcoin/bitcoin/blob/d0f6d9953a15d7c7111d46dcb76ab2bb18e5dee3/src/qt/bitcoinstrings.cpp#L1

    In the case of the source string removed in #33453, this line won’t affect the translation at runtime.

  4. hebasto closed this on Oct 13, 2025


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-28 06:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me