contrib: Fix gen-manpages.py to check build options #33617

pull ac12644 wants to merge 1 commits into bitcoin:master from ac12644:fix-gen-manpages-build-options changing 1 files +58 −1
  1. ac12644 commented at 10:05 pm on October 13, 2025: none

    The gen-manpages.py script was missing critical build option checks, causing incomplete man page generation. This commit adds comprehensive build option detection to ensure all available options are documented.

    Changes made:

    • Add missing USE_UPNP build option detection (core requirement from #17506)
    • Remove unused build options that were listed but not actually used
    • Add error handling for missing ‘components’ section in config.ini
    • Improve code structure with proper function organization

    The script now prevents generation of incomplete man pages by all required build options and provides clear error messages when components are missing. Users can use –skip-build-options-check to bypass this check if needed.

    Fixes #17506

  2. contrib: Fix gen-manpages.py to check build options
    - Add missing USE_UPNP build option
    - Fix grammar in error message
    - Remove unused build options (ENABLE_BITCOIN_CHAINSTATE, ENABLE_FUZZ_BINARY, ENABLE_USDT_TRACEPOINTS)
    - Add error handling for missing 'components' section
    - Improve code structure and organization
    
    Fixes #17506
    c392202d71
  3. DrahtBot added the label Scripts and tools on Oct 13, 2025
  4. DrahtBot commented at 10:05 pm on October 13, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33617.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

  5. maflcko commented at 6:15 am on October 14, 2025: member
    How is this different from #33085 ?
  6. ac12644 commented at 7:01 am on October 14, 2025: none

    How is this different from #33085 ? @maflcko made several important improvements: Added USE_UPNP Removed unused options - Addressed your feedback about ENABLE_BITCOIN_CHAINSTATE, ENABLE_FUZZ_BINARY, ENABLE_USDT_TRACEPOINTS Fixed grammar - “Aborting generation of…” instead of “Aborting generating…”

  7. ac12644 force-pushed on Oct 14, 2025
  8. ac12644 closed this on Oct 14, 2025

  9. ac12644 deleted the branch on Oct 14, 2025
  10. maflcko commented at 7:12 am on October 14, 2025: member
    It may be good to retain the original author in the commit. This can be achieved by cherry-picking or by adding the co-authored-by tag. Otherwise, it looks like you fully authored this yourself.
  11. ac12644 restored the branch on Oct 14, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-10-31 09:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me