test: multisig verify spend from 100 of 999 taproot multisig wallet #33658

pull ubbabeck wants to merge 2 commits into bitcoin:master from ubbabeck:mulitsig-test changing 2 files +56 −18
  1. ubbabeck commented at 12:20 pm on October 19, 2025: none

    depends on: miniscript: fixes #29098 by only use first k valid signatures #31719 related to: ** test: verify spend from 999-of-999 taproot multisig wallet #28212**

    Testing of #31719 to test if it is a proper candidate ref #28212 (comment).

    Seems to help on my computer the test takes build/test/functional/wallet_taproot.py 33.31s user 1.08s system 97% cpu 35.114 total to complete.

    feel free to close the pr if it is excessive

  2. miniscript: fixes #29098 by only use first k valid signatures #31719 2e38925815
  3. test: verify spend from 999-of-999 taproot multisig wallet #28212
     test of https://github.com/bitcoin/bitcoin/pull/28212 rebased on top of https://github.com/bitcoin/bitcoin/pull/31719
    a4764eed25
  4. DrahtBot added the label Tests on Oct 19, 2025
  5. DrahtBot commented at 12:20 pm on October 19, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33658.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    Conflicts

    Reviewers, this pull request conflicts with the following ones:

    • #32964 (descriptor: don’t underestimate the size of a Taproot spend (instead, overestimate it) by w0xlt)

    If you consider this pull request important, please also help to review the conflicting pull requests. Ideally, start with the one that should be merged first.

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • validate -> valid [comment should read “if number of valid signatures…” — “validate” is the wrong form here]
    • when add with sat with valid stacks -> when adding sat with valid stacks [use “adding” to make the clause grammatical and clear]

    drahtbot_id_5_m

  6. ubbabeck commented at 8:03 am on October 20, 2025: none
    Closing this as it’s rather trivial to add once the #29098 and rather focus on testing and reviewing it.
  7. ubbabeck closed this on Oct 20, 2025


ubbabeck DrahtBot

Labels
Tests


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-06 06:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me