The following mining-related RPC calls don't use the wallet:
- getnetworkhashps
- getmininginfo
- getblocktemplate
- submitblock
Enable them when compiling with --disable-wallet.
Allow mining RPCs with --disable-wallet #3368
pull laanwj wants to merge 3 commits into bitcoin:master from laanwj:2013_11_disable_wallet_mining changing 8 files +104 −82-
laanwj commented at 2:29 PM on December 8, 2013: member
-
sipa commented at 8:33 PM on December 8, 2013: member
ACK code changes. Haven't tested.
-
4a85e06750
Allow mining RPCs with --disable-wallet
The following mining-related RPC calls don't use the wallet: - getnetworkhashps - getmininginfo - getblocktemplate - submitblock Enable them when compiling with --disable-wallet.
-
Move internal miner functionality together acfa03337e
-
laanwj commented at 8:00 AM on December 9, 2013: member
I see I forgot to re-enable the miner tests in --disable-wallet compiles. The mining tests are using CReserveKey (and thus the wallet), but this looks pretty simple to avoid as the state of the wallet is never checked.
-
fbc7a96d03
Re-enable miner tests in --disable-wallet mode
Use a fixed script instead of a CReserveKey from the wallet. This does not affect the functionality or result of the tests as they never check the state of the wallet in the first place.
-
BitcoinPullTester commented at 9:16 AM on December 9, 2013: none
Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/fbc7a96d03200e55021c9e04f7fa9114272e6960 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
- gavinandresen referenced this in commit d47bbbd261 on Dec 10, 2013
- gavinandresen merged this on Dec 10, 2013
- gavinandresen closed this on Dec 10, 2013
- laanwj deleted the branch on Apr 9, 2014
- Bushstar referenced this in commit 8211ff0a8a on Apr 8, 2020
- DrahtBot locked this on Sep 8, 2021
Contributors