ThreadGetMyExternalIP crash at shutdown #3372

issue gavinandresen opened this issue on December 9, 2013
  1. gavinandresen commented at 3:11 AM on December 9, 2013: contributor

    Compiling with -DDEBUG_LOCKORDER, I found a crash-at-shutdown bug due to ThreadGetMyExternalIP calling AddLocal() after Shutdown()/global destructors.

    I believe the fix is to have ThreadGetMyExternalIP be part of the network thread group, so Shutdown interrupts it and waits for it it finish.

    This is hard to reproduce; I had to try several times starting up and almost immediately stopping to get a crash (stop has to happen after ThreadGetMyExternalIP is started, but before it is done).

  2. gavinandresen referenced this in commit 65e9062c96 on Dec 9, 2013
  3. gavinandresen referenced this in commit 80ecf6702a on Dec 9, 2013
  4. gavinandresen closed this on Dec 9, 2013

  5. MathyV referenced this in commit ff0d80d6f4 on Aug 4, 2014
  6. MathyV referenced this in commit 752899043e on Aug 5, 2014
  7. Bushstar referenced this in commit 975f73be7a on Apr 8, 2020
  8. MarcoFalke locked this on Sep 8, 2021

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-13 21:15 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me