[Qt] make address field in editaddressdialog validated #3375

• use a QValidatedLineEdit in editaddressdialog.ui
• small constructor formating changes

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/c0807892b1462101c590e023f94f172a973e0e94 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.

@laanwj Do you agree?

I don't grasp it entirely. What is the behavioral change here?

As it's a btc address input, we can use the btc address validator ;).

@laanwj Merge-Ping ;)

What does this change? You make it a ValidatedLineInput but you don't set a validator, or use setValid anywhere.

You are wrong, we use GUIUtil::setupAddressWidget(ui->addressEdit, this);... in editaddressdialog.cpp.

Ok, but does this have any change in the behavior?

Let me word it differently: How to test this?

The address validator kicks in and doesn't let you enter dissallowed characters and such things... we should use that for every btc-address input field. I think it's just plain right to use QValidatedLineEdit here (even if it my have worked before, which I didn't test).

Sure, I also think that this isn't a very bad idea. But I do think you're confusing two things:

1. setValidator

2. ValidatedLineEdit

3. setValidator works for every LineEdit, not just ValidatedLineEdit. The Validator filters everything that is entered into the field, and prevents anything non-validated from ending up in the field in the first place.

4. ValidatedLineEdit is an alternative approach at validation. It is there to support validation at form submit time, ie by turning invalid fields red to point the user at their mistake. This is done by using the setValid call.

I think approach (2) is usually better, at least for non-trivial validations such as checking whether an address is correct. However, it requires more work than just changing the field class :)

I'm re-working the validator-stuff currently, remember that onFocusOut check I added there. This pull ensures all btc address input fields work the same, even if there is currently no obvious benefit or behavioural change. All other address fields are also using ValidatedLineEdits.

Integrated in #3286, closing.