test: Format strings in test_runner #33753

pull rustaceanrob wants to merge 1 commits into bitcoin:master from rustaceanrob:10-31-runner-clippy changing 3 files +16 −20
  1. rustaceanrob commented at 11:10 am on October 31, 2025: contributor
    format! strings may contain variables within the string representation. This is a lint as of a recent rustc nightly version.
  2. DrahtBot added the label Tests on Oct 31, 2025
  3. DrahtBot commented at 11:11 am on October 31, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33753.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK TheCharlatan, rkrux, maflcko

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. maflcko commented at 11:17 am on October 31, 2025: member

    Thanks. It makes sense to be clippy-clean and just consistently apply the shorter and easier-to-read variant.

    lgtm ACK d305b865c9630646a6cf7d227c08ba4263a379f7

  5. test: Format strings in `*.rs`
    `format!` strings may contain variables within the string
    representation. This is a lint as of a recent `rustc` nightly version.
    78d4d36730
  6. rustaceanrob force-pushed on Oct 31, 2025
  7. rustaceanrob commented at 1:42 pm on October 31, 2025: contributor
    I found the lint in additional files and have updated accordingly in 78d4d36730d44de93690b43f900a9202517291f6
  8. TheCharlatan approved
  9. TheCharlatan commented at 1:51 pm on October 31, 2025: contributor
    ACK 78d4d36730d44de93690b43f900a9202517291f6
  10. DrahtBot requested review from maflcko on Oct 31, 2025
  11. rkrux approved
  12. rkrux commented at 2:32 pm on October 31, 2025: contributor
    crACK 78d4d36730d44de93690b43f900a9202517291f6
  13. maflcko commented at 2:41 pm on October 31, 2025: member
    lgtm ACK 78d4d36730d44de93690b43f900a9202517291f6
  14. fanquake merged this on Oct 31, 2025
  15. fanquake closed this on Oct 31, 2025

  16. rustaceanrob deleted the branch on Oct 31, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-02 18:12 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me