clang-tidy: Remove no longer needed NOLINT #33781

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:251104-nolint changing 1 files +1 −1
  1. hebasto commented at 5:47 pm on November 4, 2025: member

    From https://github.com/bitcoin/bitcoin/pull/33714/files#r2491476516:

    Actually, the NOLINT was fixed and can be removed? You’ve confirmed that it is undeclared on the listed platforms, so it can’t be hit by readability-redundant-declaration

  2. clang-tidy: Remove no longer needed NOLINT 038849e2e0
  3. DrahtBot commented at 5:47 pm on November 4, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33781.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, l0rinc

    If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.

  4. maflcko commented at 5:53 pm on November 4, 2025: member
    lgtm ACK 038849e2e09bb9f4ce1fb5a1f291745506c6a52d
  5. l0rinc commented at 9:08 pm on November 4, 2025: contributor
    I wanted to ask the same on the original PR but forgot - ACK 038849e2e09bb9f4ce1fb5a1f291745506c6a52d
  6. fanquake merged this on Nov 5, 2025
  7. fanquake closed this on Nov 5, 2025

  8. hebasto deleted the branch on Nov 5, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-11-21 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me