From https://github.com/bitcoin/bitcoin/pull/33714/files#r2491476516:
Actually, the
NOLINTwas fixed and can be removed? You've confirmed that it is undeclared on the listed platforms, so it can't be hit byreadability-redundant-declaration
clang-tidy: Remove no longer needed NOLINT #33781
pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:251104-nolint changing 1 files +1 −1-
hebasto commented at 5:47 PM on November 4, 2025: member
-
clang-tidy: Remove no longer needed NOLINT 038849e2e0
-
DrahtBot commented at 5:47 PM on November 4, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33781.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process.
If your review is incorrectly listed, please react with 👎 to this comment and the bot will ignore it on the next update.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
-
maflcko commented at 5:53 PM on November 4, 2025: member
lgtm ACK 038849e2e09bb9f4ce1fb5a1f291745506c6a52d
-
l0rinc commented at 9:08 PM on November 4, 2025: contributor
I wanted to ask the same on the original PR but forgot - ACK 038849e2e09bb9f4ce1fb5a1f291745506c6a52d
- fanquake merged this on Nov 5, 2025
- fanquake closed this on Nov 5, 2025
- hebasto deleted the branch on Nov 5, 2025
