Remove mapRequestCount from wallet #3380

1. 
   laanwj commented at 10:17 am on December 10, 2013: member

   (I’m not 100% sure about this – maybe these statistics are useful to keep track of for other reasons, just throwing this out there as a possibility for wallet interface simplification)

   Maprequestcount in the wallet is used to keep track of the number of requests that a certain block/transaction has had.

   However, this does not affect the behavior in any way, and is not reported over RPC in any way. It is only used for some obscure stats in the GUI which I think would be slightly useful for people solo-mining using the GUI.

   This also makes the “Inventory” signal no longer necessary.

2. Remove mapRequestCount from wallet

   Maprequestcount in the wallet is used to keep track of the number of requests
   that a certain block/transaction has had.
   
   However, this does not affect the behavior in any way, and is not
   reported over RPC in any way. It is only used for some obscure stats in the GUI
   which I think would be slightly useful for people solo-mining using the GUI.
   
   This also makes the "Inventory" signal no longer necessary.

   bf07e26a9b
3. 
   BitcoinPullTester commented at 10:38 am on December 10, 2013: none

   Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/bf07e26a9bc780a4a32050b81c765f287505c5e4 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
4. 
   sipa commented at 9:33 pm on December 12, 2013: member

   I’m not sure about removing it. Knowing whether peers have your transactions is useful - if the GUI and/or RPC don’t expose it (properly), then perhaps that should be fixed.

   On the other hand, BitcoinJ’s method may actually be more interesting: relaying your transactions only to some peers, and checking whether you see it being announced by others.

5. 
   laanwj commented at 4:03 am on December 13, 2013: member

   Ok, closing then
6. laanwj closed this on Dec 13, 2013

   ---

7. Bushstar referenced this in commit a5a3e51554 on Apr 8, 2020
8. DrahtBot locked this on Sep 8, 2021

Contributors
laanwj BitcoinPullTester sipa