[Qt] fix RecentRequestsTableModel function ambuguity #3381

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:fix_misc changing 2 files +14 −6

Diapolo commented at 11:00 AM on December 10, 2013: none
- fixes a compiler error with ::createIndex() called in RecentRequestsTableModel::index()
- also add some Q_UNUSED() macros

[Qt] fix RecentRequestsTableModel function ambiuguity

- fixes a compiler ambiguity error with ::createIndex() called in
  RecentRequestsTableModel::index()
- also add some Q_UNUSED() macros

7df07b3f45

in src/qt/recentrequeststablemodel.cpp:None in d1aada2f85 outdated
```
  92 | @@ -88,12 +93,15 @@ QVariant RecentRequestsTableModel::headerData(int section, Qt::Orientation orien
  93 |  
  94 |  QModelIndex RecentRequestsTableModel::index(int row, int column, const QModelIndex &parent) const
  95 |  {
  96 | -    return createIndex(row, column, 0);
  97 | +    Q_UNUSED(parent);
  98 | +
  99 | +    return QAbstractTableModel::createIndex(row, column);
```
laanwj commented at 11:26 AM on December 10, 2013:

Are you sure that the "QAbstractTableModel::" is needed here?

Diapolo commented at 1:38 PM on December 11, 2013:

My local Qt5 build gave me a warning on that line and compiles fine now... perhaps it also works with just removing the 0...

Diapolo commented at 1:46 PM on December 11, 2013:

Removing the 0 also works and looks cleaner :).
BitcoinPullTester commented at 2:21 PM on December 11, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/7df07b3f456958288fe6787be6bee503d5dbb034 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
Diapolo referenced this in commit 666893b1fa on Dec 18, 2013
laanwj referenced this in commit 97203994a4 on Dec 18, 2013
laanwj merged this on Dec 18, 2013
laanwj closed this on Dec 18, 2013
Diapolo deleted the branch on Dec 18, 2013
Bushstar referenced this in commit 17ece14f40 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

Diapolo

laanwj

BitcoinPullTester