[Qt] fix possibilty to delete even last sendcoins entry #3382

pull Diapolo wants to merge 1 commits into bitcoin:master from Diapolo:sendcoinsentry changing 1 files +6 −4

Diapolo commented at 11:03 AM on December 10, 2013: none
- this bug was introduced when switching to deleteLater() call when deleting entries
laanwj commented at 11:10 AM on December 10, 2013: member

This bug was not introduced when switching to deleteLater. Try testing the commit directly before that.
Diapolo commented at 11:17 AM on December 10, 2013: none

@laanwj I assumed that was the case, because I remember during my sendcoins changes I verified that I can't delete the last entry. Anyway, do you just want me to remove the description ;)?
laanwj commented at 11:21 AM on December 10, 2013: member

I just want to be sure that we know the correct cause of the behavior change. I remember that I also noticed this behavior back when I changed it to deleteLater and then tested the previous version and the behavior was already there. It could be that I made a git mistake though...
laanwj commented at 11:28 AM on December 10, 2013: member

Seems you were right. Sorry :)

[Qt] fix possibilty to delete last sendcoins entry

- hide the entry about to be deleted, and if it is the last entry add a
  new one, so that we always have one entry in our list

24646ee76f

in src/qt/sendcoinsdialog.cpp:None in 418381520c outdated
```
 305 | @@ -306,12 +306,12 @@ void SendCoinsDialog::updateTabsAndLabels()
 306 |  
 307 |  void SendCoinsDialog::removeEntry(SendCoinsEntry* entry)
 308 |  {
 309 | -    entry->deleteLater();
```
laanwj commented at 11:33 AM on December 10, 2013:

I think this can be improved further by adding a entry->hide() here.

With this patch it looks like there are two entries for a very slight moment.

Diapolo commented at 1:35 PM on December 11, 2013:

That is a great suggestion, I'll update the pull... updated!
BitcoinPullTester commented at 2:10 PM on December 11, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/24646ee76f060a4590d074e80aebeb6665cb5ae1 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
laanwj referenced this in commit 5e47c2b70a on Dec 11, 2013
laanwj merged this on Dec 11, 2013
laanwj closed this on Dec 11, 2013
Diapolo deleted the branch on Dec 11, 2013
Bushstar referenced this in commit deba865b17 on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors