. #33834

pull 777genius wants to merge 1 commits into bitcoin:master from 777genius:refactor/txgraph-bool-comparisons changing 1 files +9 −9
  1. 777genius commented at 6:14 PM on November 9, 2025: none

    .

  2. refactor: Remove redundant boolean comparisons in txgraph.cpp
    Replace explicit boolean comparisons with idiomatic C++ boolean evaluation.

Changes:
- Replace 'clusterset.m_oversized == true' with 'clusterset.m_oversized' (6 instances)
- Replace 'clusterset.m_oversized == false' with '!clusterset.m_oversized' (3 instances)

This improves code readability while maintaining exact semantic equivalence.
All modifications are within conditional statements checking the m_oversized
member variable.

🤖 Generated with [Claude Code](https://claude.com/claude-code)

Co-Authored-By: Claude <noreply@anthropic.com>
    d2e5ad6c2c
  3. DrahtBot added the label Refactoring on Nov 9, 2025
  4. DrahtBot commented at 6:14 PM on November 9, 2025: contributor

    <!--e57a25ab6845829454e8d69fc972939a-->

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    <!--006a51241073e994b41acfe9ec718e94-->

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33834.

    <!--021abf342d371248e50ceaed478a90ca-->

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    <!--5faf32d7da4f0f540f40219e4f7537a3-->

  5. in src/txgraph.cpp:712 in d2e5ad6c2c 
     708 | @@ -709,7 +709,7 @@ class TxGraphImpl final : public TxGraph
 709 |                  // a formerly-oversized main graph while staging exists (to satisfy chunk feerate
 710 |                  // queries into main, for example), and such merges could conflict with pulls of
 711 |                  // some of their constituents into staging.
 712 | -                if (level == GetTopLevel() && clusterset.m_oversized == true) {
    l0rinc commented at 6:31 PM on November 9, 2025:

    NACK, m_oversized is an std::optional<bool>

  6. l0rinc commented at 6:42 PM on November 9, 2025: contributor

    Refactors are usually appreciated if they're a precursor to a bigger change with a generally desired outcome. Doing changes just to satisfy Sonar or an IDE or an LLM without understanding the context is usually frowned upon - review takes up a lot of our time, it's hard to justify why we should spend it on checking subjective changes without an obvious advantage.

  7. achow101 renamed this:
    refactor: Remove redundant boolean comparisons in txgraph.cpp
    .
    on Nov 9, 2025
  8. bitcoin locked this on Nov 9, 2025
  9. bitcoin deleted a comment on Nov 9, 2025
  10. fanquake removed the label Refactoring on Nov 10, 2025
Contributors
777geniusDrahtBotl0rinc
github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-04-29 03:12 UTC
This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me