.
. #33836
pull 777genius wants to merge 1 commits into bitcoin:master from 777genius:refactor/bool-comparisons-cleanup changing 4 files +4 −4-
777genius commented at 6:16 PM on November 9, 2025: none
-
6e5e857f1f
refactor: Remove redundant boolean comparisons across codebase
Replace explicit boolean comparisons with idiomatic C++ boolean evaluation in multiple files. Changes: - src/script/interpreter.cpp: 'CastToBool(...) == false' → '!CastToBool(...)' - src/addrman.cpp: 'fInTried == false' → '!fInTried' - src/policy/fees/block_policy_estimator.cpp: 'passing == true' → 'passing' - src/util/subprocess.h: 'force == false && argument.empty() == false' → '!force && !argument.empty()' All changes improve code readability while maintaining exact semantic equivalence. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
- DrahtBot added the label Refactoring on Nov 9, 2025
-
DrahtBot commented at 6:16 PM on November 9, 2025: contributor
<!--e57a25ab6845829454e8d69fc972939a-->
The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.
<!--006a51241073e994b41acfe9ec718e94-->
Code Coverage & Benchmarks
For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33836.
<!--021abf342d371248e50ceaed478a90ca-->
Reviews
See the guideline for information on the review process. A summary of reviews will appear here.
<!--5faf32d7da4f0f540f40219e4f7537a3-->
- bitcoin deleted a comment on Nov 9, 2025
- bitcoin locked this on Nov 9, 2025
- achow101 renamed this:
refactor: Remove redundant boolean comparisons across codebase
.
on Nov 9, 2025 - fanquake removed the label Refactoring on Nov 10, 2025
