kernel: allow null data_directory #33867

1. 
   stickies-v commented at 10:43 pm on November 12, 2025: contributor

   An empty path may be represented with a nullptr. For example, std::string_view::data() may return nullptr.

   Removes the BITCOINKERNEL_ARG_NONNULL attribute for data_directory, and instead handles such null arguments in the implementation.

   Also documents how BITCOINKERNEL_ARG_NONNULL should be used.

   Follow-up to #33853#pullrequestreview-3454620265

2. kernel: allow null data_directory

   An empty path may be represented with a nullptr. For example,
   std::string_view::data() may return nullptr.
   
   Removes the BITCOINKERNEL_ARG_NONNULL attribute for data_directory,
   and instead handles such null arguments in the implementation.
   
   Also documents how BITCOINKERNEL_ARG_NONNULL should be used.

   1dee29ef47
3. DrahtBot added the label Validation on Nov 12, 2025
4. 
   DrahtBot commented at 10:43 pm on November 12, 2025: contributor

   The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

   Code Coverage & Benchmarks

   For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33867.

   Reviews

   See the guideline for information on the review process. A summary of reviews will appear here.

   LLM Linter (✨ experimental)

   Possible typos and grammar issues:

   • “will associate” -> “will be associated” [passive voice needed: “the created options and … the chainstate manager will be associated with this kernel context” makes the sentence grammatically correct]

   drahtbot_id_5_m

Contributors
stickies-v DrahtBot

Labels
Validation