qt: add "Show all" option in "receiving addresses" #3390

pull laanwj wants to merge 1 commits into bitcoin:master from laanwj:2013_12_qt_show_all_addresses changing 6 files +175 −64

laanwj commented at 11:18 AM on December 11, 2013: member
Extra information for nosy people. Add "Show all" option in "receiving addresses" to show change, keypool, refund etc addresses. These can only be viewed, not edited.

If you think this should be in the client, please help testing.

Known issues, need to be solved before merging:
- New keypool addresses are not added to the dialog without a client restart
- Addresses don't change from (keypool) to (change) when sending a transaction without a client restart
qt: add "Show all" option in "receiving addresses"
Extra information for nosy people.
19ab9bc2c5
BitcoinPullTester commented at 11:58 AM on December 11, 2013: none

Automatic sanity-testing: PASSED, see http://jenkins.bluematt.me/pull-tester/19ab9bc2c52584058558af7ad59d1e4bcd301172 for binaries and test log. This test script verifies pulls every time they are updated. It, however, dies sometimes and fails to test properly. If you are waiting on a test, please check timestamps to verify that the test.log is moving at http://jenkins.bluematt.me/pull-tester/current/ Contact BlueMatt on freenode if something looks broken.
in src/qt/addresstablemodel.cpp:None in 19ab9bc2c5
```
  33 | +    bool inAddressBook;
  34 |  
  35 |      AddressTableEntry() {}
  36 | -    AddressTableEntry(Type type, const QString &label, const QString &address):
  37 | -        type(type), label(label), address(address) {}
  38 | +    AddressTableEntry(Type type, const QString &label, const QString &address, const QString &purpose,
```
Diapolo commented at 1:55 PM on December 11, 2013:

Do you mind doing something like (this is hard to read currently IMHO):

<pre> AddressTableEntry(Type type, const QString &label, const QString &address, const QString &purpose, bool inAddressBook) : type(type), label(label), address(address), purpose(purpose), inAddressBook(inAddressBook) { } </pre>
in src/qt/addresstablemodel.cpp:None in 19ab9bc2c5
```
 282 |      editStatus = OK;
 283 |  
 284 |      if(role == Qt::EditRole)
 285 |      {
 286 | +        LOCK(wallet->cs_wallet);
 287 | +        CTxDestination curAddress = CBitcoinAddress(rec->address.toStdString()).Get();
```
Diapolo commented at 1:57 PM on December 11, 2013:

The address is validated somewhere before adding it here, right?

laanwj commented at 2:09 PM on December 11, 2013:

This does validation as well: it returns a CNoDestination if the address is invalid.
Diapolo commented at 1:58 PM on December 11, 2013: none

Very nice addition IMHO, I like that kind of information.
laanwj commented at 7:45 AM on January 7, 2014: member

Closing this for now
laanwj closed this on Jan 7, 2014
Bushstar referenced this in commit 1aba86567b on Apr 8, 2020
DrahtBot locked this on Sep 8, 2021

Contributors

laanwj

BitcoinPullTester

Diapolo