cmake: Make BUILD_KERNEL_TEST depend on BUILD_KERNEL_LIB #33972

pull hebasto wants to merge 1 commits into bitcoin:master from hebasto:251130-kernel-test changing 1 files +1 −1
  1. hebasto commented at 1:45 pm on November 30, 2025: member

    The CMake script in the test/kernel subdirectory is already gated by BUILD_KERNEL_LIB:https://github.com/bitcoin/bitcoin/blob/f6acbef1084e34f126bf530df99e4ef6a11c38e8/src/CMakeLists.txt#L405-L409

    As a result, the following configuration summary is misleading:

    0$ cmake -B build -DBUILD_KERNEL_LIB=OFF -DBUILD_KERNEL_TEST=ON
    1<snip>
    2  bitcoin-chainstate (experimental) ... OFF
    3  libbitcoinkernel (experimental) ..... OFF
    4  kernel-test (experimental) .......... ON
    5<snip>
    

    This PR fixes the behaviour by making the BUILD_KERNEL_TEST option explicitly depend on BUILD_KERNEL_LIB.

  2. cmake: Make `BUILD_KERNEL_TEST` depend on `BUILD_KERNEL_LIB` fe1815d48f
  3. hebasto added the label Build system on Nov 30, 2025
  4. DrahtBot commented at 1:46 pm on November 30, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33972.

    Reviews

    See the guideline for information on the review process.

    Type Reviewers
    ACK maflcko, sedited

    If your review is incorrectly listed, please copy-paste <!–meta-tag:bot-skip–> into the comment that the bot should ignore.

  5. hebasto commented at 1:47 pm on November 30, 2025: member
  6. maflcko commented at 8:18 am on December 1, 2025: member
    lgtm ACK fe1815d48f0cee57d2f1af50b377c7f9e462369e
  7. sedited approved
  8. sedited commented at 8:44 am on December 1, 2025: contributor
    ACK fe1815d48f0cee57d2f1af50b377c7f9e462369e
  9. fanquake merged this on Dec 1, 2025
  10. fanquake closed this on Dec 1, 2025

  11. hebasto deleted the branch on Dec 1, 2025

github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2025-12-01 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me