2025 11 self advertise in separate message #33987

pull 0xB10C wants to merge 2 commits into bitcoin:master from 0xB10C:2025-11-self-advertise-in-separate-message changing 3 files +114 −3
  1. 0xB10C commented at 5:23 pm on December 1, 2025: contributor
    wip; PR for CI
  2. test: address self-annoucement
    Test that a node sends a self-annoucement with its external IP to a peer.
    The self-annoucmenent can be contained in an addr(v2) message along with
    multiple other addresses. In these test-cases, it's contained in the response
    to a GETADDR message along with other addresses.
    209c60622a
  3. p2p: self-advertise our address in separate msg
    TODO
    cc4d6c111e
  4. DrahtBot commented at 5:23 pm on December 1, 2025: contributor

    The following sections might be updated with supplementary metadata relevant to reviewers and maintainers.

    Code Coverage & Benchmarks

    For details see: https://corecheck.dev/bitcoin/bitcoin/pulls/33987.

    Reviews

    See the guideline for information on the review process. A summary of reviews will appear here.

    LLM Linter (✨ experimental)

    Possible typos and grammar issues:

    • self-annoucement -> self-announcement [misspelling; should be “announcement”]
      Contexts: C++ comment “// Send the initial self-annoucement…” and Python comments “# The self-annoucement…” (multiple added lines)

    • self-annoucements -> self-announcements [misspelling; should be “announcements”]
      Context: C++ comment “// All later self-annoucements are send together…” (also appears as variable names in code but only the comment is addressed)

    • are send -> are sent [incorrect verb form]
      Context: C++ comment “// All later self-annoucements are send together with the other addresses.”

    2025-12-01

  5. 0xB10C closed this on Dec 1, 2025

  6. 0xB10C commented at 5:23 pm on December 1, 2025: contributor
    should have been against my fork… https://github.com/0xB10C/bitcoin/pull/13


0xB10C DrahtBot


github-metadata-mirror

This is a metadata mirror of the GitHub repository bitcoin/bitcoin. This site is not affiliated with GitHub. Content is generated from a GitHub metadata backup.
generated: 2026-03-03 21:13 UTC

This site is hosted by @0xB10C
More mirrored repositories can be found on mirror.b10c.me